summaryrefslogtreecommitdiffstats
path: root/Python
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@haypocalc.com>2011-05-03 13:09:24 (GMT)
committerVictor Stinner <victor.stinner@haypocalc.com>2011-05-03 13:09:24 (GMT)
commit0a92d1849e17dd4008f0d190ecc47b5c55260f3b (patch)
treede70579731bc4ef35edb33b11dfb4124a634a190 /Python
parent645b9f67aef1f6c8921cf5f8bbe6db3fa94418bc (diff)
downloadcpython-0a92d1849e17dd4008f0d190ecc47b5c55260f3b.zip
cpython-0a92d1849e17dd4008f0d190ecc47b5c55260f3b.tar.gz
cpython-0a92d1849e17dd4008f0d190ecc47b5c55260f3b.tar.bz2
Issue #8651: PyArg_Parse*() functions raise an OverflowError if the file
doesn't have PY_SSIZE_T_CLEAN define and the size doesn't fit in an int (length bigger than 2^31-1 bytes).
Diffstat (limited to 'Python')
-rw-r--r--Python/getargs.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/Python/getargs.c b/Python/getargs.c
index 02351ed6..eccdc9b 100644
--- a/Python/getargs.c
+++ b/Python/getargs.c
@@ -585,7 +585,17 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags,
#define FETCH_SIZE int *q=NULL;Py_ssize_t *q2=NULL;\
if (flags & FLAG_SIZE_T) q2=va_arg(*p_va, Py_ssize_t*); \
else q=va_arg(*p_va, int*);
-#define STORE_SIZE(s) if (flags & FLAG_SIZE_T) *q2=s; else *q=s;
+#define STORE_SIZE(s) \
+ if (flags & FLAG_SIZE_T) \
+ *q2=s; \
+ else { \
+ if (INT_MAX < s) { \
+ PyErr_SetString(PyExc_OverflowError, \
+ "size does not fit in an int"); \
+ return converterr("", arg, msgbuf, bufsize); \
+ } \
+ *q=s; \
+ }
#define BUFFER_LEN ((flags & FLAG_SIZE_T) ? *q2:*q)
const char *format = *p_format;