diff options
| author | Neal Norwitz <nnorwitz@gmail.com> | 2005-11-14 00:18:03 (GMT) |
|---|---|---|
| committer | Neal Norwitz <nnorwitz@gmail.com> | 2005-11-14 00:18:03 (GMT) |
| commit | e8c0536d57d58a40d7bb8d81034bb9ba196fd078 (patch) | |
| tree | 54a3b77c6e24a923d9849fca065ac3948bf3a36e /Python | |
| parent | 7b3d5e177941f910bbf20a9345213b51b7be6a87 (diff) | |
| download | cpython-e8c0536d57d58a40d7bb8d81034bb9ba196fd078.zip cpython-e8c0536d57d58a40d7bb8d81034bb9ba196fd078.tar.gz cpython-e8c0536d57d58a40d7bb8d81034bb9ba196fd078.tar.bz2 | |
Fix memory leak with bad generator expression
Diffstat (limited to 'Python')
| -rw-r--r-- | Python/ast.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/Python/ast.c b/Python/ast.c index e483650..548710f 100644 --- a/Python/ast.c +++ b/Python/ast.c @@ -1901,6 +1901,7 @@ ast_for_expr_stmt(struct compiling *c, const node *n) if (!expr1) return NULL; if (expr1->kind == GeneratorExp_kind) { + free_expr(expr1); ast_error(ch, "augmented assignment to generator " "expression not possible"); return NULL; @@ -1908,6 +1909,7 @@ ast_for_expr_stmt(struct compiling *c, const node *n) if (expr1->kind == Name_kind) { char *var_name = PyString_AS_STRING(expr1->v.Name.id); if (var_name[0] == 'N' && !strcmp(var_name, "None")) { + free_expr(expr1); ast_error(ch, "assignment to None"); return NULL; } @@ -1918,12 +1920,17 @@ ast_for_expr_stmt(struct compiling *c, const node *n) expr2 = ast_for_testlist(c, ch); else expr2 = Yield(ast_for_expr(c, ch), LINENO(ch)); - if (!expr2) + if (!expr2) { + free_expr(expr1); return NULL; + } operator = ast_for_augassign(CHILD(n, 1)); - if (!operator) + if (!operator) { + free_expr(expr1); + free_expr(expr2); return NULL; + } return AugAssign(expr1, operator, expr2, LINENO(n)); } @@ -1964,7 +1971,7 @@ ast_for_expr_stmt(struct compiling *c, const node *n) else expression = ast_for_expr(c, value); if (!expression) - return NULL; + goto error; return Assign(targets, expression, LINENO(n)); error: for (i = i / 2; i >= 0; i--) |