summaryrefslogtreecommitdiffstats
path: root/Python
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2012-10-01 22:55:07 (GMT)
committerVictor Stinner <victor.stinner@gmail.com>2012-10-01 22:55:07 (GMT)
commit3b635cd4476422fbef7e1da1e1de66bbb939d648 (patch)
treeb72249b1d9573c4ae91c6031af4d1e1a0f0d0a29 /Python
parentf25dabe1ec01d8547de06dd73c59afde3370c216 (diff)
downloadcpython-3b635cd4476422fbef7e1da1e1de66bbb939d648.zip
cpython-3b635cd4476422fbef7e1da1e1de66bbb939d648.tar.gz
cpython-3b635cd4476422fbef7e1da1e1de66bbb939d648.tar.bz2
Close #15766: Catch exceptions while raising the ImportError in imp.load_dynamic()
Diffstat (limited to 'Python')
-rw-r--r--Python/dynload_shlib.c25
1 files changed, 18 insertions, 7 deletions
diff --git a/Python/dynload_shlib.c b/Python/dynload_shlib.c
index 0ca65c7..6df6199 100644
--- a/Python/dynload_shlib.c
+++ b/Python/dynload_shlib.c
@@ -129,19 +129,30 @@ dl_funcptr _PyImport_GetDynLoadFunc(const char *shortname,
handle = dlopen(pathname, dlopenflags);
if (handle == NULL) {
- PyObject *mod_name = NULL;
- PyObject *path = NULL;
- PyObject *error_ob = NULL;
+ PyObject *mod_name;
+ PyObject *path;
+ PyObject *error_ob;
const char *error = dlerror();
if (error == NULL)
error = "unknown dlopen() error";
error_ob = PyUnicode_FromString(error);
- path = PyUnicode_FromString(pathname);
+ if (error_ob == NULL)
+ return NULL;
mod_name = PyUnicode_FromString(shortname);
+ if (mod_name == NULL) {
+ Py_DECREF(error_ob);
+ return NULL;
+ }
+ path = PyUnicode_FromString(pathname);
+ if (path == NULL) {
+ Py_DECREF(error_ob);
+ Py_DECREF(mod_name);
+ return NULL;
+ }
PyErr_SetImportError(error_ob, mod_name, path);
- Py_XDECREF(error_ob);
- Py_XDECREF(path);
- Py_XDECREF(mod_name);
+ Py_DECREF(error_ob);
+ Py_DECREF(mod_name);
+ Py_DECREF(path);
return NULL;
}
if (fp != NULL && nhandles < 128)