diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2016-11-16 13:41:11 (GMT) |
|---|---|---|
| committer | Serhiy Storchaka <storchaka@gmail.com> | 2016-11-16 13:41:11 (GMT) |
| commit | fab6acd9f58584d2f4b361418e4d17f9c23db2f9 (patch) | |
| tree | aee38e54448d48d8652ab4c62792ca414d4653f3 /Python | |
| parent | 3b73ea127892d0e1f9d8f12f88e4f9c0ba0b89b1 (diff) | |
| parent | f5894dd646f5e39918377b37b8c8694cebdca103 (diff) | |
| download | cpython-fab6acd9f58584d2f4b361418e4d17f9c23db2f9.zip cpython-fab6acd9f58584d2f4b361418e4d17f9c23db2f9.tar.gz cpython-fab6acd9f58584d2f4b361418e4d17f9c23db2f9.tar.bz2 | |
Issue #28701: Replace _PyUnicode_CompareWithId with _PyUnicode_EqualToASCIIId.
The latter function is more readable, faster and doesn't raise exceptions.
Based on patch by Xiang Zhang.
Diffstat (limited to 'Python')
| -rw-r--r-- | Python/errors.c | 2 | ||||
| -rw-r--r-- | Python/pythonrun.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/Python/errors.c b/Python/errors.c index 918f4df..7b25a22 100644 --- a/Python/errors.c +++ b/Python/errors.c @@ -984,7 +984,7 @@ PyErr_WriteUnraisable(PyObject *obj) goto done; } else { - if (_PyUnicode_CompareWithId(moduleName, &PyId_builtins) != 0) { + if (!_PyUnicode_EqualToASCIIId(moduleName, &PyId_builtins)) { if (PyFile_WriteObject(moduleName, f, Py_PRINT_RAW) < 0) goto done; if (PyFile_WriteString(".", f) < 0) diff --git a/Python/pythonrun.c b/Python/pythonrun.c index 1fc86c0..5b1b786 100644 --- a/Python/pythonrun.c +++ b/Python/pythonrun.c @@ -751,7 +751,7 @@ print_exception(PyObject *f, PyObject *value) err = PyFile_WriteString("<unknown>", f); } else { - if (_PyUnicode_CompareWithId(moduleName, &PyId_builtins) != 0) + if (!_PyUnicode_EqualToASCIIId(moduleName, &PyId_builtins)) { err = PyFile_WriteObject(moduleName, f, Py_PRINT_RAW); err += PyFile_WriteString(".", f); |