diff options
| author | Steve Dower <steve.dower@microsoft.com> | 2017-10-05 20:35:36 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-05 20:35:36 (GMT) |
| commit | 2084b30e540d88b9fc752c5bdcc2f24334af4f2b (patch) | |
| tree | d3e924741d52f43f1e574a8fd6cb3f33e7f4fa19 /Tools/msi/uploadrelease.proj | |
| parent | 36c1d1f1e52ba54007cbecb42c5599e5ff62aa52 (diff) | |
| download | cpython-2084b30e540d88b9fc752c5bdcc2f24334af4f2b.zip cpython-2084b30e540d88b9fc752c5bdcc2f24334af4f2b.tar.gz cpython-2084b30e540d88b9fc752c5bdcc2f24334af4f2b.tar.bz2 | |
bpo-31523: Reliability improvements to the Windows build files (#3900)
Diffstat (limited to 'Tools/msi/uploadrelease.proj')
| -rw-r--r-- | Tools/msi/uploadrelease.proj | 35 |
1 files changed, 18 insertions, 17 deletions
diff --git a/Tools/msi/uploadrelease.proj b/Tools/msi/uploadrelease.proj index 75840f2..881b825 100644 --- a/Tools/msi/uploadrelease.proj +++ b/Tools/msi/uploadrelease.proj @@ -10,7 +10,6 @@ <IncludeDoc Condition="'$(IncludeDoc)' == ''">true</IncludeDoc> <BuildForRelease Condition="'$(BuildForRelease)' == ''">true</BuildForRelease> <DryRun Condition="'$(DryRun)' == ''">false</DryRun> - <Purge Condition="'$(Purge)' == ''">false</Purge> </PropertyGroup> <Import Project="msi.props" /> @@ -43,7 +42,8 @@ <Target Name="_RunGpg" Condition="'$(GPG)' != ''" Inputs="@(File)" Outputs="$(IntermediateOutputPath)\gpg\%(FileName)%(Extension).asc"> <MakeDir Directories="$(IntermediateOutputPath)gpg" /> <Delete Files="$(IntermediateOutputPath)\gpg\%(File.FileName)%(File.Extension).asc" Condition="Exists('$(IntermediateOutputPath)\gpg\%(File.FileName)%(File.Extension).asc')" /> - <Exec Command=""$(GPG)" -ba -o "$(IntermediateOutputPath)\gpg\%(File.FileName)%(File.Extension).asc" "%(File.FullPath)"" /> + <Exec Command=""$(GPG)" -ba -o "$(IntermediateOutputPath)\gpg\%(File.FileName)%(File.Extension).asc" "%(File.FullPath)"" + IgnoreExitCode="false" /> <ItemGroup> <File Include="$(IntermediateOutputPath)\gpg\%(File.FileName)%(File.Extension).asc"> <CopyTo>%(File.CopyTo)</CopyTo> @@ -52,23 +52,15 @@ </Target> <Target Name="_Upload" Condition="!$(DryRun)"> - <Exec Command=""$(PLINK)" $(User)@$(Host) mkdir %(File.CopyTo) ^&^& chgrp downloads %(File.CopyTo) ^&^& chmod g-w,o+rx %(File.CopyTo) -"$(PSCP)" @(File,' ') $(User)@$(Host):%(File.CopyTo) -"$(PLINK)" $(User)@$(Host) chgrp downloads %(File.CopyTo)/*; chmod g-w,o+r %(File.CopyTo)/* -" /> + <Exec Command=""$(PLINK)" $(User)@$(Host) mkdir %(File.CopyTo) ^&^& chgrp downloads %(File.CopyTo) ^&^& chmod g-w,o+rx %(File.CopyTo)" /> + <Exec Command=""$(PSCP)" @(File,' ') $(User)@$(Host):%(File.CopyTo)" /> + <Exec Command=""$(PLINK)" $(User)@$(Host) chgrp downloads %(File.CopyTo)/*; chmod g-w,o+r %(File.CopyTo)/*" /> </Target> <Target Name="_PrintNames" Condition="$(DryRun)"> - <Exec Command="echo "$(PLINK)" $(User)@$(Host) mkdir %(File.CopyTo) ^&^& chgrp downloads %(File.CopyTo) ^&^& chmod g-w,o+rx %(File.CopyTo) -echo "$(PSCP)" @(File,' ') $(User)@$(Host):%(File.CopyTo) -echo "$(PLINK)" $(User)@$(Host) chgrp downloads %(File.CopyTo)/*; chmod g-w,o+r %(File.CopyTo)/* -echo. -echo." /> - </Target> - - <Target Name="_Purge" Condition="$(Purge) and !$(DryRun)"> - <Error Condition="!Exists('$(PythonExe)')" Text="No Python executable available at $(PythonExe)" /> - <Exec Command=""$(PythonExe)" purge.py $(PythonVersion)" /> + <Exec Command="echo "$(PLINK)" $(User)@$(Host) mkdir %(File.CopyTo) ^&^& chgrp downloads %(File.CopyTo) ^&^& chmod g-w,o+rx %(File.CopyTo)" /> + <Exec Command="echo "$(PSCP)" @(File,' ') $(User)@$(Host):%(File.CopyTo)" /> + <Exec Command="echo "$(PLINK)" $(User)@$(Host) chgrp downloads %(File.CopyTo)/*; chmod g-w,o+r %(File.CopyTo)/*" /> </Target> <Target Name="_TestLayout"> @@ -82,6 +74,7 @@ echo." /> <LogFile>$(OutputPath)\%(Filename)_layoutlog\%(Filename).log</LogFile> </WebInstaller> </ItemGroup> + <Error Text="Could not find installer" Condition="@(WebInstaller) == ''" /> <RemoveDir Directories="%(WebInstaller.SourceDir)" Condition="Exists('%(WebInstaller.SourceDir)')" /> <RemoveDir Directories="%(WebInstaller.LayoutDir)" Condition="Exists('%(WebInstaller.LayoutDir)')" /> <RemoveDir Directories="%(WebInstaller.LogDir)" Condition="Exists('%(WebInstaller.LogDir)')" /> @@ -95,14 +88,22 @@ echo." /> <Message Text="Successfully downloaded %(WebInstaller.Filename)%(WebInstaller.Extension) layout" Importance="high" /> </Target> - <Target Name="Upload" DependsOnTargets="_ValidateProperties;_RunGpg;_PrintNames;_Upload;_Purge" /> + <Target Name="Upload" DependsOnTargets="_ValidateProperties;_RunGpg;_PrintNames;_Upload" /> <Target Name="Test" DependsOnTargets="_TestLayout" /> + <Target Name="Purge"> + <Error Condition="!Exists('$(PythonExe)')" Text="No Python executable available at $(PythonExe)" /> + <Exec Command="echo "$(PythonExe)" purge.py $(PythonVersion)" Condition="$(DryRun)" /> + <Exec Command=""$(PythonExe)" purge.py $(PythonVersion)" Condition="!$(DryRun)" /> + <Message Text="Purged uploaded files" Importance="high" /> + </Target> + <Target Name="ShowHashes"> <ItemGroup> <UserFiles Include="@(File)" Condition="'%(File.CopyTo)' == '$(EXETarget)'" /> </ItemGroup> + <Error Text="No files generated" Condition="@(UserFiles) == ''" /> <Exec Command=""$(PythonExe)" generate_md5.py @(UserFiles->'"%(FullPath)"',' ')" /> </Target> |