summaryrefslogtreecommitdiffstats
path: root/Tools
diff options
context:
space:
mode:
authorPablo Galindo <Pablogsal@gmail.com>2020-09-03 14:29:55 (GMT)
committerGitHub <noreply@github.com>2020-09-03 14:29:55 (GMT)
commite55a0e971b4bf9e6473bf0ca6bebdff76c075ef6 (patch)
tree5dca77a9c05b0075139bdbd4762a643f782e114e /Tools
parent315a61f7a9418d904e0eea14b1f054fac3a90e9f (diff)
downloadcpython-e55a0e971b4bf9e6473bf0ca6bebdff76c075ef6.zip
cpython-e55a0e971b4bf9e6473bf0ca6bebdff76c075ef6.tar.gz
cpython-e55a0e971b4bf9e6473bf0ca6bebdff76c075ef6.tar.bz2
Fix 'gather' rules in the python parser generator (GH-22021)
Currently, empty sequences in gather rules make the conditional for gather rules fail as empty sequences evaluate as "False". We need to explicitly check for "None" (the failure condition) to avoid false negatives.
Diffstat (limited to 'Tools')
-rw-r--r--Tools/peg_generator/pegen/python_generator.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/Tools/peg_generator/pegen/python_generator.py b/Tools/peg_generator/pegen/python_generator.py
index 45a7597..b786de7 100644
--- a/Tools/peg_generator/pegen/python_generator.py
+++ b/Tools/peg_generator/pegen/python_generator.py
@@ -217,6 +217,9 @@ class PythonParserGenerator(ParserGenerator, GrammarVisitor):
else:
self.print("and")
self.visit(item)
+ if is_gather:
+ self.print("is not None")
+
self.print("):")
with self.indent():
action = node.action