diff options
-rw-r--r-- | Lib/ssl.py | 2 | ||||
-rw-r--r-- | Lib/test/test_ssl.py | 4 | ||||
-rw-r--r-- | Misc/ACKS | 1 | ||||
-rw-r--r-- | Misc/NEWS | 3 |
4 files changed, 9 insertions, 1 deletions
@@ -361,7 +361,7 @@ def DER_cert_to_PEM_cert(der_cert_bytes): # preferred because older API gets line-length wrong f = base64.standard_b64encode(der_cert_bytes) return (PEM_HEADER + '\n' + - textwrap.fill(f, 64) + + textwrap.fill(f, 64) + '\n' + PEM_FOOTER + '\n') else: return (PEM_HEADER + '\n' + diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py index cc04f4c..e5f4a9e 100644 --- a/Lib/test/test_ssl.py +++ b/Lib/test/test_ssl.py @@ -116,6 +116,10 @@ class BasicTests(unittest.TestCase): p2 = ssl.DER_cert_to_PEM_cert(d1) d2 = ssl.PEM_cert_to_DER_cert(p2) self.assertEqual(d1, d2) + if not p2.startswith(ssl.PEM_HEADER + '\n'): + self.fail("DER-to-PEM didn't include correct header:\n%r\n" % p2) + if not p2.endswith('\n' + ssl.PEM_FOOTER + '\n'): + self.fail("DER-to-PEM didn't include correct footer:\n%r\n" % p2) def test_refcycle(self): # Issue #7943: an SSL object doesn't create reference cycles with @@ -734,6 +734,7 @@ Lionel Ulmer Roger Upole Michael Urman Hector Urtubia +Kyle VanderBeek Atul Varma Dmitry Vasiliev Alexandre Vassalotti @@ -33,6 +33,9 @@ Core and Builtins Library ------- +- Issue #8086: In :func:`ssl.DER_cert_to_PEM_cert()`, fix missing newline + before the certificate footer. Patch by Kyle VanderBeek. + - Issue #8549: Fix compiling the _ssl extension under AIX. Patch by Sridhar Ratnakumar. |