diff options
| -rw-r--r-- | Lib/test/audiotests.py | 6 | ||||
| -rw-r--r-- | Lib/test/test_wave.py | 11 | ||||
| -rw-r--r-- | Lib/wave.py | 4 | ||||
| -rw-r--r-- | Misc/NEWS | 3 |
4 files changed, 21 insertions, 3 deletions
diff --git a/Lib/test/audiotests.py b/Lib/test/audiotests.py index 59e99287..008281f 100644 --- a/Lib/test/audiotests.py +++ b/Lib/test/audiotests.py @@ -6,7 +6,8 @@ import pickle import sys def byteswap2(data): - a = array.array('h', data) + a = array.array('h') + a.frombytes(data) a.byteswap() return a.tobytes() @@ -17,7 +18,8 @@ def byteswap3(data): return bytes(ba) def byteswap4(data): - a = array.array('i', data) + a = array.array('i') + a.frombytes(data) a.byteswap() return a.tobytes() diff --git a/Lib/test/test_wave.py b/Lib/test/test_wave.py index cf069ae..5be1251 100644 --- a/Lib/test/test_wave.py +++ b/Lib/test/test_wave.py @@ -48,6 +48,12 @@ class WavePCM16Test(audiotests.AudioWriteTests, if sys.byteorder != 'big': frames = audiotests.byteswap2(frames) + if sys.byteorder == 'big': + @unittest.expectedFailure + def test_unseekable_incompleted_write(self): + super().test_unseekable_incompleted_write() + + class WavePCM24Test(audiotests.AudioWriteTests, audiotests.AudioTestsWithSourceFile, @@ -108,6 +114,11 @@ class WavePCM32Test(audiotests.AudioWriteTests, if sys.byteorder != 'big': frames = audiotests.byteswap4(frames) + if sys.byteorder == 'big': + @unittest.expectedFailure + def test_unseekable_incompleted_write(self): + super().test_unseekable_incompleted_write() + if __name__ == '__main__': unittest.main() diff --git a/Lib/wave.py b/Lib/wave.py index 6285c74..4a22345 100644 --- a/Lib/wave.py +++ b/Lib/wave.py @@ -424,7 +424,9 @@ class Wave_write: data = self._convert(data) if self._sampwidth in (2, 4) and sys.byteorder == 'big': import array - data = array.array(_array_fmts[self._sampwidth], data) + a = array.array(_array_fmts[self._sampwidth]) + a.frombytes(data) + data = a assert data.itemsize == self._sampwidth data.byteswap() data.tofile(self._file) @@ -13,6 +13,9 @@ Core and Builtins Library ------- +- Issue #19633: Fixed writing not compressed 16- and 32-bit wave files on + big-endian platforms. + - Issue #19449: in csv's writerow, handle non-string keys when generating the error message that certain keys are not in the 'fieldnames' list. |