summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Misc/NEWS2
-rw-r--r--Objects/odictobject.c2
2 files changed, 3 insertions, 1 deletions
diff --git a/Misc/NEWS b/Misc/NEWS
index 51257de..9a3d0a3 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -37,6 +37,8 @@ Library
- Issue #24362: Simplify the C OrderedDict fast nodes resize logic.
+- Issue #24377: Fix a ref leak in OrderedDict.__repr__.
+
What's New in Python 3.5.0 beta 2?
==================================
diff --git a/Objects/odictobject.c b/Objects/odictobject.c
index 79ac826..55055ac 100644
--- a/Objects/odictobject.c
+++ b/Objects/odictobject.c
@@ -1578,7 +1578,7 @@ odict_repr(PyODictObject *self)
if (value == NULL) {
if (!PyErr_Occurred())
PyErr_SetObject(PyExc_KeyError, key);
- return NULL;
+ goto Done;
}
pair = PyTuple_Pack(2, key, value);
if (pair == NULL)