summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Lib/plistlib.py2
-rw-r--r--Lib/test/test_plistlib.py7
-rw-r--r--Misc/NEWS2
3 files changed, 10 insertions, 1 deletions
diff --git a/Lib/plistlib.py b/Lib/plistlib.py
index 4f360f3..09be5fd 100644
--- a/Lib/plistlib.py
+++ b/Lib/plistlib.py
@@ -918,7 +918,7 @@ class _BinaryPlistWriter (object):
self._write_size(0x50, len(value))
except UnicodeEncodeError:
t = value.encode('utf-16be')
- self._write_size(0x60, len(value))
+ self._write_size(0x60, len(t) // 2)
self._fp.write(t)
diff --git a/Lib/test/test_plistlib.py b/Lib/test/test_plistlib.py
index 60ff918..c77a6bf 100644
--- a/Lib/test/test_plistlib.py
+++ b/Lib/test/test_plistlib.py
@@ -360,6 +360,13 @@ class TestPlistlib(unittest.TestCase):
plistlib.dumps,
testString)
+ def test_non_bmp_characters(self):
+ pl = {'python': '\U0001f40d'}
+ for fmt in ALL_FORMATS:
+ with self.subTest(fmt=fmt):
+ data = plistlib.dumps(pl, fmt=fmt)
+ self.assertEqual(plistlib.loads(data), pl)
+
def test_nondictroot(self):
for fmt in ALL_FORMATS:
with self.subTest(fmt=fmt):
diff --git a/Misc/NEWS b/Misc/NEWS
index 4a8e0b8..1a7924d 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -50,6 +50,8 @@ Core and Builtins
Library
-------
+- Issue #28321: Fixed writing non-BMP characters with binary format in plistlib.
+
- Issue #28225: bz2 module now supports pathlib. Initial patch by Ethan Furman.
- Issue #28227: gzip now supports pathlib. Patch by Ethan Furman.