diff options
| -rw-r--r-- | Misc/NEWS | 2 | ||||
| -rw-r--r-- | Python/compile.c | 8 |
2 files changed, 10 insertions, 0 deletions
@@ -12,6 +12,8 @@ What's New in Python 2.6 alpha 2? Core and builtins ----------------- +- Add a warning when asserting a non-empty tuple which is always true. + - Issue #2179: speed up with statement execution by storing the exit method on the stack instead of in a temporary variable (patch by Jeffrey Yaskin) diff --git a/Python/compile.c b/Python/compile.c index 43b7569..47a63e7 100644 --- a/Python/compile.c +++ b/Python/compile.c @@ -2056,6 +2056,14 @@ compiler_assert(struct compiler *c, stmt_ty s) if (assertion_error == NULL) return 0; } + if (s->v.Assert.test->kind == Tuple_kind && + asdl_seq_LEN(s->v.Assert.test->v.Tuple.elts) > 0) { + const char* msg = + "assertion is always true, perhaps remove parentheses?"; + if (PyErr_WarnExplicit(PyExc_SyntaxWarning, msg, c->c_filename, + c->u->u_lineno, NULL, NULL) == -1) + return 0; + } VISIT(c, expr, s->v.Assert.test); end = compiler_new_block(c); if (end == NULL) |