diff options
| -rw-r--r-- | Misc/NEWS | 3 | ||||
| -rw-r--r-- | Modules/posixmodule.c | 11 |
2 files changed, 13 insertions, 1 deletions
@@ -93,6 +93,9 @@ Core and Builtins Extensions ---------- +- Issue #7736: Release the GIL around calls to opendir() and closedir() + in the posix module. Patch by Marcin Bachry. + - Issue #4835: make PyLong_FromSocket_t() and PyLong_AsSocket_t() private to the socket module, and fix the width of socket descriptors to be correctly detected under 64-bit Windows. diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index ce625b4..1080c7e 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -2580,11 +2580,16 @@ posix_listdir(PyObject *self, PyObject *args) oname = PyBytes_FromString("."); } name = PyBytes_AsString(oname); - if ((dirp = opendir(name)) == NULL) { + Py_BEGIN_ALLOW_THREADS + dirp = opendir(name); + Py_END_ALLOW_THREADS + if (dirp == NULL) { return posix_error_with_allocated_filename(oname); } if ((d = PyList_New(0)) == NULL) { + Py_BEGIN_ALLOW_THREADS closedir(dirp); + Py_END_ALLOW_THREADS Py_DECREF(oname); return NULL; } @@ -2597,7 +2602,9 @@ posix_listdir(PyObject *self, PyObject *args) if (errno == 0) { break; } else { + Py_BEGIN_ALLOW_THREADS closedir(dirp); + Py_END_ALLOW_THREADS Py_DECREF(d); return posix_error_with_allocated_filename(oname); } @@ -2621,7 +2628,9 @@ posix_listdir(PyObject *self, PyObject *args) } Py_DECREF(v); } + Py_BEGIN_ALLOW_THREADS closedir(dirp); + Py_END_ALLOW_THREADS Py_DECREF(oname); return d; |