summaryrefslogtreecommitdiffstats
path: root/Objects
diff options
context:
space:
mode:
Diffstat (limited to 'Objects')
-rw-r--r--Objects/typeobject.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 2d001b7..eec25b0 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -6474,9 +6474,15 @@ object_set_class(PyObject *self, PyObject *value, void *closure)
if (newto->tp_flags & Py_TPFLAGS_HEAPTYPE) {
Py_INCREF(newto);
}
+ Py_BEGIN_CRITICAL_SECTION(self);
+ // The real Py_TYPE(self) (`oldto`) may have changed from
+ // underneath us in another thread, so we re-fetch it here.
+ oldto = Py_TYPE(self);
Py_SET_TYPE(self, newto);
- if (oldto->tp_flags & Py_TPFLAGS_HEAPTYPE)
+ Py_END_CRITICAL_SECTION();
+ if (oldto->tp_flags & Py_TPFLAGS_HEAPTYPE) {
Py_DECREF(oldto);
+ }
RARE_EVENT_INC(set_class);
return 0;