summaryrefslogtreecommitdiffstats
path: root/PC
diff options
context:
space:
mode:
Diffstat (limited to 'PC')
-rw-r--r--PC/_subprocess.c57
1 files changed, 34 insertions, 23 deletions
diff --git a/PC/_subprocess.c b/PC/_subprocess.c
index 77a8a85..8c9a352 100644
--- a/PC/_subprocess.c
+++ b/PC/_subprocess.c
@@ -66,6 +66,14 @@ sp_handle_new(HANDLE handle)
return (PyObject*) self;
}
+#if defined(MS_WIN32) && !defined(MS_WIN64)
+#define HANDLE_TO_PYNUM(handle) PyLong_FromLong((long) handle)
+#define PY_HANDLE_PARAM "l"
+#else
+#define HANDLE_TO_PYNUM(handle) PyLong_FromLongLong((long long) handle)
+#define PY_HANDLE_PARAM "L"
+#endif
+
static PyObject*
sp_handle_detach(sp_handle_object* self, PyObject* args)
{
@@ -79,7 +87,7 @@ sp_handle_detach(sp_handle_object* self, PyObject* args)
self->handle = NULL;
/* note: return the current handle, as an integer */
- return PyLong_FromLong((long) handle);
+ return HANDLE_TO_PYNUM(handle);
}
static PyObject*
@@ -113,7 +121,7 @@ static PyMethodDef sp_handle_methods[] = {
static PyObject*
sp_handle_as_int(sp_handle_object* self)
{
- return PyLong_FromLong((long) self->handle);
+ return HANDLE_TO_PYNUM(self->handle);
}
static PyNumberMethods sp_handle_as_number;
@@ -172,7 +180,7 @@ sp_GetStdHandle(PyObject* self, PyObject* args)
}
/* note: returns integer, not handle object */
- return PyLong_FromLong((long) handle);
+ return HANDLE_TO_PYNUM(handle);
}
static PyObject *
@@ -190,14 +198,16 @@ sp_DuplicateHandle(PyObject* self, PyObject* args)
HANDLE target_handle;
BOOL result;
- long source_process_handle;
- long source_handle;
- long target_process_handle;
+ HANDLE source_process_handle;
+ HANDLE source_handle;
+ HANDLE target_process_handle;
int desired_access;
int inherit_handle;
int options = 0;
- if (! PyArg_ParseTuple(args, "lllii|i:DuplicateHandle",
+ if (! PyArg_ParseTuple(args,
+ PY_HANDLE_PARAM PY_HANDLE_PARAM PY_HANDLE_PARAM
+ "ii|i:DuplicateHandle",
&source_process_handle,
&source_handle,
&target_process_handle,
@@ -208,9 +218,9 @@ sp_DuplicateHandle(PyObject* self, PyObject* args)
Py_BEGIN_ALLOW_THREADS
result = DuplicateHandle(
- (HANDLE) source_process_handle,
- (HANDLE) source_handle,
- (HANDLE) target_process_handle,
+ source_process_handle,
+ source_handle,
+ target_process_handle,
&target_handle,
desired_access,
inherit_handle,
@@ -440,13 +450,13 @@ sp_TerminateProcess(PyObject* self, PyObject* args)
{
BOOL result;
- long process;
+ HANDLE process;
int exit_code;
- if (! PyArg_ParseTuple(args, "li:TerminateProcess", &process,
- &exit_code))
+ if (! PyArg_ParseTuple(args, PY_HANDLE_PARAM "i:TerminateProcess",
+ &process, &exit_code))
return NULL;
- result = TerminateProcess((HANDLE) process, exit_code);
+ result = TerminateProcess(process, exit_code);
if (! result)
return PyErr_SetFromWindowsErr(GetLastError());
@@ -461,11 +471,11 @@ sp_GetExitCodeProcess(PyObject* self, PyObject* args)
DWORD exit_code;
BOOL result;
- long process;
- if (! PyArg_ParseTuple(args, "l:GetExitCodeProcess", &process))
+ HANDLE process;
+ if (! PyArg_ParseTuple(args, PY_HANDLE_PARAM ":GetExitCodeProcess", &process))
return NULL;
- result = GetExitCodeProcess((HANDLE) process, &exit_code);
+ result = GetExitCodeProcess(process, &exit_code);
if (! result)
return PyErr_SetFromWindowsErr(GetLastError());
@@ -478,15 +488,15 @@ sp_WaitForSingleObject(PyObject* self, PyObject* args)
{
DWORD result;
- long handle;
+ HANDLE handle;
int milliseconds;
- if (! PyArg_ParseTuple(args, "li:WaitForSingleObject",
+ if (! PyArg_ParseTuple(args, PY_HANDLE_PARAM "i:WaitForSingleObject",
&handle,
&milliseconds))
return NULL;
Py_BEGIN_ALLOW_THREADS
- result = WaitForSingleObject((HANDLE) handle, (DWORD) milliseconds);
+ result = WaitForSingleObject(handle, (DWORD) milliseconds);
Py_END_ALLOW_THREADS
if (result == WAIT_FAILED)
@@ -508,13 +518,14 @@ static PyObject *
sp_GetModuleFileName(PyObject* self, PyObject* args)
{
BOOL result;
- long module;
+ HMODULE module;
WCHAR filename[MAX_PATH];
- if (! PyArg_ParseTuple(args, "l:GetModuleFileName", &module))
+ if (! PyArg_ParseTuple(args, PY_HANDLE_PARAM ":GetModuleFileName",
+ &module))
return NULL;
- result = GetModuleFileNameW((HMODULE)module, filename, MAX_PATH);
+ result = GetModuleFileNameW(module, filename, MAX_PATH);
filename[MAX_PATH-1] = '\0';
if (! result)