summaryrefslogtreecommitdiffstats
path: root/Python
diff options
context:
space:
mode:
Diffstat (limited to 'Python')
-rw-r--r--Python/optimizer_analysis.c11
-rw-r--r--Python/optimizer_bytecodes.c41
-rw-r--r--Python/optimizer_cases.c.h36
-rw-r--r--Python/optimizer_symbols.c9
4 files changed, 97 insertions, 0 deletions
diff --git a/Python/optimizer_analysis.c b/Python/optimizer_analysis.c
index 1e1d552..21cccdb 100644
--- a/Python/optimizer_analysis.c
+++ b/Python/optimizer_analysis.c
@@ -292,6 +292,7 @@ remove_globals(_PyInterpreterFrame *frame, _PyUOpInstruction *buffer,
#define sym_is_null _Py_uop_sym_is_null
#define sym_new_const _Py_uop_sym_new_const
#define sym_new_null _Py_uop_sym_new_null
+#define sym_has_type _Py_uop_sym_has_type
#define sym_matches_type _Py_uop_sym_matches_type
#define sym_set_null _Py_uop_sym_set_null
#define sym_set_non_null _Py_uop_sym_set_non_null
@@ -324,6 +325,16 @@ optimize_to_bool(
return 0;
}
+static void
+eliminate_pop_guard(_PyUOpInstruction *this_instr, bool exit)
+{
+ REPLACE_OP(this_instr, _POP_TOP, 0, 0);
+ if (exit) {
+ REPLACE_OP((this_instr+1), _EXIT_TRACE, 0, 0);
+ this_instr[1].target = this_instr->target;
+ }
+}
+
/* 1 for success, 0 for not ready, cannot error at the moment. */
static int
optimize_uops(
diff --git a/Python/optimizer_bytecodes.c b/Python/optimizer_bytecodes.c
index 2cf5427..ee67a2b 100644
--- a/Python/optimizer_bytecodes.c
+++ b/Python/optimizer_bytecodes.c
@@ -21,6 +21,7 @@ typedef struct _Py_UOpsAbstractFrame _Py_UOpsAbstractFrame;
#define sym_new_const _Py_uop_sym_new_const
#define sym_new_null _Py_uop_sym_new_null
#define sym_matches_type _Py_uop_sym_matches_type
+#define sym_has_type _Py_uop_sym_has_type
#define sym_set_null _Py_uop_sym_set_null
#define sym_set_non_null _Py_uop_sym_set_non_null
#define sym_set_type _Py_uop_sym_set_type
@@ -36,6 +37,8 @@ optimize_to_bool(
_Py_UopsSymbol *value,
_Py_UopsSymbol **result_ptr);
+extern void
+eliminate_pop_guard(_PyUOpInstruction *this_instr, bool exit)
static int
dummy_func(void) {
@@ -557,7 +560,45 @@ dummy_func(void) {
(void)iter;
}
+ op(_GUARD_IS_TRUE_POP, (flag -- )) {
+ if (sym_is_const(flag)) {
+ PyObject *value = sym_get_const(flag);
+ assert(value != NULL);
+ eliminate_pop_guard(this_instr, value != Py_True);
+ }
+ }
+
+ op(_GUARD_IS_FALSE_POP, (flag -- )) {
+ if (sym_is_const(flag)) {
+ PyObject *value = sym_get_const(flag);
+ assert(value != NULL);
+ eliminate_pop_guard(this_instr, value != Py_False);
+ }
+ }
+
+ op(_GUARD_IS_NONE_POP, (flag -- )) {
+ if (sym_is_const(flag)) {
+ PyObject *value = sym_get_const(flag);
+ assert(value != NULL);
+ eliminate_pop_guard(this_instr, !Py_IsNone(value));
+ }
+ else if (sym_has_type(flag)) {
+ assert(!sym_matches_type(flag, &_PyNone_Type));
+ eliminate_pop_guard(this_instr, true);
+ }
+ }
+ op(_GUARD_IS_NOT_NONE_POP, (flag -- )) {
+ if (sym_is_const(flag)) {
+ PyObject *value = sym_get_const(flag);
+ assert(value != NULL);
+ eliminate_pop_guard(this_instr, Py_IsNone(value));
+ }
+ else if (sym_has_type(flag)) {
+ assert(!sym_matches_type(flag, &_PyNone_Type));
+ eliminate_pop_guard(this_instr, false);
+ }
+ }
// END BYTECODES //
diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h
index f2c186a..6e65e2e 100644
--- a/Python/optimizer_cases.c.h
+++ b/Python/optimizer_cases.c.h
@@ -1803,21 +1803,57 @@
/* _INSTRUMENTED_POP_JUMP_IF_NOT_NONE is not a viable micro-op for tier 2 */
case _GUARD_IS_TRUE_POP: {
+ _Py_UopsSymbol *flag;
+ flag = stack_pointer[-1];
+ if (sym_is_const(flag)) {
+ PyObject *value = sym_get_const(flag);
+ assert(value != NULL);
+ eliminate_pop_guard(this_instr, value != Py_True);
+ }
stack_pointer += -1;
break;
}
case _GUARD_IS_FALSE_POP: {
+ _Py_UopsSymbol *flag;
+ flag = stack_pointer[-1];
+ if (sym_is_const(flag)) {
+ PyObject *value = sym_get_const(flag);
+ assert(value != NULL);
+ eliminate_pop_guard(this_instr, value != Py_False);
+ }
stack_pointer += -1;
break;
}
case _GUARD_IS_NONE_POP: {
+ _Py_UopsSymbol *flag;
+ flag = stack_pointer[-1];
+ if (sym_is_const(flag)) {
+ PyObject *value = sym_get_const(flag);
+ assert(value != NULL);
+ eliminate_pop_guard(this_instr, !Py_IsNone(value));
+ }
+ else if (sym_has_type(flag)) {
+ assert(!sym_matches_type(flag, &_PyNone_Type));
+ eliminate_pop_guard(this_instr, true);
+ }
stack_pointer += -1;
break;
}
case _GUARD_IS_NOT_NONE_POP: {
+ _Py_UopsSymbol *flag;
+ flag = stack_pointer[-1];
+ if (sym_is_const(flag)) {
+ PyObject *value = sym_get_const(flag);
+ assert(value != NULL);
+ eliminate_pop_guard(this_instr, Py_IsNone(value));
+ }
+ else if (sym_has_type(flag)) {
+ assert(!sym_matches_type(flag, &_PyNone_Type));
+ eliminate_pop_guard(this_instr, false);
+ }
stack_pointer += -1;
break;
}
diff --git a/Python/optimizer_symbols.c b/Python/optimizer_symbols.c
index 29fe31a..86b0d4d 100644
--- a/Python/optimizer_symbols.c
+++ b/Python/optimizer_symbols.c
@@ -232,6 +232,15 @@ _Py_uop_sym_new_null(_Py_UOpsContext *ctx)
}
bool
+_Py_uop_sym_has_type(_Py_UopsSymbol *sym)
+{
+ if (_Py_uop_sym_is_bottom(sym)) {
+ return false;
+ }
+ return sym->typ != NULL;
+}
+
+bool
_Py_uop_sym_matches_type(_Py_UopsSymbol *sym, PyTypeObject *typ)
{
assert(typ != NULL && PyType_Check(typ));