Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Don't memoize the empty tuple in protocol 0. | Guido van Rossum | 2003-01-28 | 1 | -1/+2 | |
| | ||||||
* | save_tuple(): So long as the charter is rewriting for clarity, the snaky | Tim Peters | 2003-01-28 | 1 | -21/+20 | |
| | | | | control flow had to be simplified. | |||||
* | save_tuple(): I believe the new code for TUPLE{1,2,3} in proto 2 was | Tim Peters | 2003-01-28 | 1 | -2/+5 | |
| | | | | | incorrect for recursive tuples. Tried to repair; seems to work OK, but there are no checked-in tests for this yet. | |||||
* | OK, this is really the last one tonight! | Guido van Rossum | 2003-01-28 | 1 | -1/+12 | |
| | | | | NEWFALSE and NEWTRUE. | |||||
* | More protocol 2: TUPLE1, TUPLE2, TUPLE3. | Guido van Rossum | 2003-01-28 | 1 | -11/+35 | |
| | | | | Also moved the special case for empty tuples from save() to save_tuple(). | |||||
* | save_inst(): Rewrote to have only one branch on self.bin. Also got rid | Tim Peters | 2003-01-28 | 1 | -16/+9 | |
| | | | | | of my recent XXX comment, taking a (what appears to be vanishingly small) chance and calling self.memoize() instead. | |||||
* | First baby steps towards implementing protocol 2: PROTO, LONG1 and LONG4. | Guido van Rossum | 2003-01-28 | 1 | -1/+88 | |
| | ||||||
* | Fixed odd whitespace after "if", which I believe I introduced long ago. | Tim Peters | 2003-01-28 | 1 | -1/+1 | |
| | ||||||
* | save_int(): Fixed two new off-by-1 glitches. | Tim Peters | 2003-01-28 | 1 | -2/+2 | |
| | ||||||
* | Add a comment explaining that struct.pack() beats marshal.dumps(), but | Guido van Rossum | 2003-01-28 | 1 | -0/+3 | |
| | | | | | marshal.loads() beats struct.unpack()! Possibly because the latter creates a one-tuple. :-( | |||||
* | Got rid of mdumps; I timed it, and struct.pack("<i", x) is more than | Guido van Rossum | 2003-01-28 | 1 | -30/+26 | |
| | | | | | 40% faster than marshal.dumps(x)[1:]! (That's not counting the module attribute lookups, which can be avoided in either case.) | |||||
* | save_tuple(): Minor rewriting, and added a comment about the subtlety | Tim Peters | 2003-01-28 | 1 | -8/+13 | |
| | | | | created by recursive tuples. | |||||
* | load_appends(): replaced .append() loop with an .extend(). | Tim Peters | 2003-01-28 | 1 | -3/+1 | |
| | ||||||
* | Comments. | Tim Peters | 2003-01-28 | 1 | -1/+9 | |
| | ||||||
* | save_dict(): Untangled most of the bin-vs-not-bin logic. Also used | Tim Peters | 2003-01-28 | 1 | -15/+14 | |
| | | | | | iteritems() instead of materializing a (possibly giant) list of the items. | |||||
* | save_list(): Rewrote, to untangle the proto 0 from the proto 1 cases. | Tim Peters | 2003-01-28 | 1 | -15/+17 | |
| | | | | The code is much easier to follow now, and I bet it's faster too. | |||||
* | save_list(): removed unused local "d". | Tim Peters | 2003-01-28 | 1 | -2/+0 | |
| | ||||||
* | save_list(): removed unused local "memo". | Tim Peters | 2003-01-28 | 1 | -1/+0 | |
| | ||||||
* | save_pers(): Switched the order of cases, to get rid of a "not", and to | Tim Peters | 2003-01-28 | 1 | -3/+3 | |
| | | | | | make the bin-vs-not-bin order consistent with what other routines try to do (they almost all handle the bin case first). | |||||
* | Several routines appeared to inline the guts of memoize(), possibly for | Tim Peters | 2003-01-28 | 1 | -12/+9 | |
| | | | | | | some notion of low-level efficiency. Undid that, but left one routine alone: save_inst() claims it has a reason for not using memoize(). I don't understand that comment, so added an XXX comment there. | |||||
* | save(): Fiddled the control flow to put the normal case where it | Tim Peters | 2003-01-28 | 1 | -44/+47 | |
| | | | | | belongs. This is a much smaller change than it may appear: the bulk of the function merely got unindented by one level. | |||||
* | Added XXX about save()'s special-casing of tuples -- I don't get it. | Tim Peters | 2003-01-28 | 1 | -0/+1 | |
| | ||||||
* | save_bool(): simplified. | Tim Peters | 2003-01-28 | 1 | -4/+1 | |
| | ||||||
* | Repaired grammar in new comment. | Tim Peters | 2003-01-28 | 1 | -1/+1 | |
| | ||||||
* | clear_memo(): Repaired grammar in docstring. | Tim Peters | 2003-01-28 | 1 | -3/+3 | |
| | ||||||
* | Added one-line comments to the proto 2 opcodes. | Tim Peters | 2003-01-28 | 1 | -14/+14 | |
| | ||||||
* | Removed the new LONG2 opcode: it's extravagant. If LONG1 isn't enough, | Tim Peters | 2003-01-28 | 1 | -7/+6 | |
| | | | | | | | | | | | | | | | | | | | then the embedded argument consumes at least 256 bytes. The difference between a 3-byte prefix (LONG2 + 2 bytes) and a 5-byte prefix (LONG4 + 4 bytes) is at worst less than 1%. Note that binary strings and binary Unicode strings also have only "size is 1 byte, or size is 4 bytes?" flavors, and I expect for the same reason. The only place a 2-byte thingie was used was in BININT2, where the 2 bytes make up the *entire* embedded argument (and now EXT2 also does this); that's a large savings over 4 bytes, because the total opcode+argument size is so small in the BININT2/EXT2 case. Removed the TAKEN_FROM_ARGUMENT "number of bytes" code, and bifurcated it into TAKEN_FROM_ARGUMENT1 and TAKEN_FROM_ARGUMENT4. Now there's enough info in ArgumentDescriptor objects to deduce the # of bytes consumed by each opcode. Rearranged the order in which proto2 opcodes are listed in pickle.py. | |||||
* | Begin the change from 'binary vs. text mode' to 'protocol 0, 1, 2'. | Guido van Rossum | 2003-01-27 | 1 | -11/+24 | |
| | | | | The protocol now defaults to 1. Protocol 2 is still unimplemented. | |||||
* | Begin documenting protocol 2. | Guido van Rossum | 2003-01-27 | 1 | -0/+16 | |
| | ||||||
* | Added some comments. | Tim Peters | 2003-01-27 | 1 | -0/+2 | |
| | ||||||
* | memoize(): Reworded the docs to try to disentangle the Pickler's memo | Tim Peters | 2003-01-27 | 1 | -7/+11 | |
| | | | | dict from the Unpickler's memo (which is a different beast!). | |||||
* | Using marshal functions to pack & unpack 1-byte ints is an obscure & | Tim Peters | 2003-01-27 | 1 | -11/+10 | |
| | | | | expensive way to spell chr() and ord(). | |||||
* | Added a brief comment to each pickle opcode declaration. | Tim Peters | 2003-01-27 | 1 | -45/+50 | |
| | ||||||
* | Raise PicklingError when __reduce__() fails, and | Jeremy Hylton | 2003-01-24 | 1 | -32/+30 | |
| | | | | | | | | | | | add memoize() helper function to update the memo. The first element of the tuple returned by __reduce__() must be a callable. If it isn't the Unpickler will raise an error. Catch this error in the pickler and raise the error there. The memoize() helper also has a comment explaining how the memo works. So methods can't use memoize() because the write funny codes. | |||||
* | Remove inst_persistent_id() WANNI (we ain't never needed it). | Jeremy Hylton | 2002-11-13 | 1 | -15/+6 | |
| | | | | Add some simple tests of the persistence hooks. | |||||
* | Fiddle comments and variable names in whichmodule(). | Jeremy Hylton | 2002-09-19 | 1 | -11/+10 | |
| | ||||||
* | whichmodule() should skip dummy package entries in sys.modules. | Jeremy Hylton | 2002-09-19 | 1 | -0/+2 | |
| | | | | | | | | This fixes the charming, but unhelpful error message for >>> pickle.dumps(type.__new__) Can't pickle <built-in method __new__ of type object at 0x812a440>: it's not the same object as datetime.math.__new__ Bugfix candidate. | |||||
* | Patch #505705: Remove eval in pickle and cPickle. | Martin v. Löwis | 2002-08-14 | 1 | -3/+10 | |
| | ||||||
* | Given the persistent id code a shot at a class before calling save_global(). | Jeremy Hylton | 2002-07-16 | 1 | -5/+5 | |
| | | | | | Some persistent picklers (well, probably, the *only* persistent pickler) would like to pickle some classes in a special way. | |||||
* | Code modernization. Replace v=s[i]; del s[i] with single lookup v=s.pop(i) | Raymond Hettinger | 2002-06-30 | 1 | -14/+6 | |
| | ||||||
* | SF 563203. Replaced 'has_key()' with 'in'. | Raymond Hettinger | 2002-06-01 | 1 | -4/+4 | |
| | ||||||
* | Remove comment about inheritance, look one line up | Neal Norwitz | 2002-05-30 | 1 | -5/+1 | |
| | ||||||
* | Patch 560023 adding docstrings. 2.2 Candidate (after verifying modules were ↵ | Raymond Hettinger | 2002-05-29 | 1 | -3/+69 | |
| | | | | not updated after 2.2). | |||||
* | Whitespace normalization. | Tim Peters | 2002-05-23 | 1 | -1/+1 | |
| | ||||||
* | Patch 533291. Deprecate None return form of __reduce__. | Raymond Hettinger | 2002-05-21 | 1 | -0/+4 | |
| | ||||||
* | Add Pickler.clear_memo() so the pickle and cPickle modules are more similar. | Fred Drake | 2002-05-01 | 1 | -0/+3 | |
| | ||||||
* | Implement an idea by Paul Rubin: | Guido van Rossum | 2002-04-05 | 1 | -14/+12 | |
| | | | | | | | | Change pickling format for bools to use a backwards compatible encoding. This means you can pickle True or False on Python 2.3 and Python 2.2 or before will read it back as 1 or 0. The code used for pickling bools before would create pickles that could not be read in previous Python versions. | |||||
* | Add the 'bool' type and its values 'False' and 'True', as described in | Guido van Rossum | 2002-04-03 | 1 | -0/+18 | |
| | | | | | | | | | | | | | PEP 285. Everything described in the PEP is here, and there is even some documentation. I had to fix 12 unit tests; all but one of these were printing Boolean outcomes that changed from 0/1 to False/True. (The exception is test_unicode.py, which did a type(x) == type(y) style comparison. I could've fixed that with a single line using issubtype(x, type(y)), but instead chose to be explicit about those places where a bool is expected. Still to do: perhaps more documentation; change standard library modules to return False/True from predicates. | |||||
* | Fix for SF 502085. | Guido van Rossum | 2002-03-26 | 1 | -1/+5 | |
| | | | | | | Don't die when issubclass(t, TypeType) fails. Bugfix candidate (but I think it's too late for 2.2.1). | |||||
* | SF #515018, delete global variable that was apparently used only | Neal Norwitz | 2002-02-11 | 1 | -0/+1 | |
| | | | | in a list comprehension. |