summaryrefslogtreecommitdiffstats
path: root/Objects
Commit message (Collapse)AuthorAgeFilesLines
* [3.12] gh-124785: Revert "[3.12] gh-116510: Fix a crash due to shared ↵Neil Schemenauer2024-10-011-42/+6
| | | | | | | immortal interned strings. (gh-124541)" (#124814) Revert "[3.12] gh-116510: Fix a crash due to shared immortal interned strings. (gh-124541)" This reverts commit 5dd07ebc0c27e2fffdfd041401c8cc7f0cda0dfc.
* [3.12] gh-113993: Make interned strings mortal (GH-120520, GH-121364, ↵Petr Viktorin2024-09-275-115/+412
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GH-121903, GH-122303) (#123065) This backports several PRs for gh-113993, making interned strings mortal so they can be garbage-collected when no longer needed. * Allow interned strings to be mortal, and fix related issues (GH-120520) * Add an InternalDocs file describing how interning should work and how to use it. * Add internal functions to *explicitly* request what kind of interning is done: - `_PyUnicode_InternMortal` - `_PyUnicode_InternImmortal` - `_PyUnicode_InternStatic` * Switch uses of `PyUnicode_InternInPlace` to those. * Disallow using `_Py_SetImmortal` on strings directly. You should use `_PyUnicode_InternImmortal` instead: - Strings should be interned before immortalization, otherwise you're possibly interning a immortalizing copy. - `_Py_SetImmortal` doesn't handle the `SSTATE_INTERNED_MORTAL` to `SSTATE_INTERNED_IMMORTAL` update, and those flags can't be changed in backports, as they are now part of public API and version-specific ABI. * Add private `_only_immortal` argument for `sys.getunicodeinternedsize`, used in refleak test machinery. Make sure the statically allocated string singletons are unique. This means these sets are now disjoint: - `_Py_ID` - `_Py_STR` (including the empty string) - one-character latin-1 singletons Now, when you intern a singleton, that exact singleton will be interned. * Add a `_Py_LATIN1_CHR` macro, use it instead of `_Py_ID`/`_Py_STR` for one-character latin-1 singletons everywhere (including Clinic). * Intern `_Py_STR` singletons at startup. * Beef up the tests. Cover internal details (marked with `@cpython_only`). * Add lots of assertions * Don't immortalize in PyUnicode_InternInPlace; keep immortalizing in other API (GH-121364) * Switch PyUnicode_InternInPlace to _PyUnicode_InternMortal, clarify docs * Document immortality in some functions that take `const char *` This is PyUnicode_InternFromString; PyDict_SetItemString, PyObject_SetAttrString; PyObject_DelAttrString; PyUnicode_InternFromString; and the PyModule_Add convenience functions. Always point out a non-immortalizing alternative. * Don't immortalize user-provided attr names in _ctypes * Immortalize names in code objects to avoid crash (GH-121903) * Intern latin-1 one-byte strings at startup (GH-122303) There are some 3.12-specific changes, mainly to allow statically allocated strings in deepfreeze. (In 3.13, deepfreeze switched to the general `_Py_ID`/`_Py_STR`.) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
* [3.12] gh-119004: fix a crash in equality testing between `OrderedDict` ↵Miss Islington (bot)2024-09-271-8/+25
| | | | | | | | (GH-121329) (#124508) gh-119004: fix a crash in equality testing between `OrderedDict` (GH-121329) (cherry picked from commit 38a887dc3ec52c4a7222279bf4b3ca2431b86de9) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
* [3.12] gh-116510: Fix a crash due to shared immortal interned strings. ↵Neil Schemenauer2024-09-271-6/+42
| | | | | | | | | (gh-124541) Fix a crash caused by immortal interned strings being shared between sub-interpreters that use basic single-phase init. In that case, the string can be used by an interpreter that outlives the interpreter that created and interned it. For interpreters that share obmalloc state, also share the interned dict with the main interpreter.
* [3.12] gh-124498: Fix `TypeAliasType` not to be generic, when ↵Miss Islington (bot)2024-09-261-1/+10
| | | | | | | | `type_params=()` (GH-124499) (#124604) gh-124498: Fix `TypeAliasType` not to be generic, when `type_params=()` (GH-124499) (cherry picked from commit abe5f799e6ce1d177f79554f1b84d348b6141045) Co-authored-by: sobolevn <mail@sobolevn.me>
* [3.12] gh-77894: Fix a crash when the GC breaks a loop containing a ↵Serhiy Storchaka2024-09-111-28/+27
| | | | | | | memoryview (GH-123898) (GH-123937) Now a memoryview object can only be cleared if there are no buffers that refer it. (cherry picked from commit a1dbf2ea69acc6ccee6292709af1dadd55c068be)
* [3.12] gh-122527: Fix a crash on deallocation of `PyStructSequence` ↵Sam Gross2024-09-061-6/+22
| | | | | | | | | | | | | | | | (GH-122577) (#122626) The `PyStructSequence` destructor would crash if it was deallocated after its type's dictionary was cleared by the GC, because it couldn't compute the "real size" of the instance. This could occur with relatively straightforward code in the free-threaded build or with a reference cycle involving the type in the default build, due to differing orders in which `tp_clear()` was called. Account for the non-sequence fields in `tp_basicsize` and use that, along with `Py_SIZE()`, to compute the "real" size of a `PyStructSequence` in the dealloc function. This avoids the accesses to the type's dictionary during dealloc, which were unsafe. (cherry picked from commit 4b63cd170e5dd840bffc80922f09f2d69932ff5c)
* [3.12] gh-122982: Extend the deprecation period for bool inversion by two ↵Miss Islington (bot)2024-08-251-2/+2
| | | | | | | | years (GH-123306) (#123317) gh-122982: Extend the deprecation period for bool inversion by two years (GH-123306) (cherry picked from commit 249b083ed8b3cfdff30bf578d7f9d3c5e982a4eb) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
* [3.12] gh-122208: Don't delivery PyDict_EVENT_ADDED until it can't fail ↵Dino Viehland2024-07-301-10/+11
| | | | | (#122327) Don't delivery PyDict_EVENT_ADDED until it can't fail
* [3.12] gh-117482: Fix the Slot Wrapper Inheritance Tests (gh-122250)Eric Snow2024-07-291-4/+19
| | | | | The tests were only checking cases where the slot wrapper was present in the initial case. They were missing when the slot wrapper was added in the additional initializations. This fixes that. (cherry-picked from commit 490e0ad83ac72c5688dfbbab4eac61ccfd7be5fd, AKA gh-122248)
* [3.12] gh-117482: Simplify the Fix For Builtin Types Slot Wrappers (gh-122241)Eric Snow2024-07-241-30/+92
| | | | | | | | | | | | | | | | | In gh-121602, I applied a fix to a builtin types initialization bug. That fix made sense in the context of some broader future changes, but introduced a little bit of extra complexity. For earlier versions those future changes are not relevant; we can avoid the extra complexity. Thus we can revert that earlier change and replace it with this one, which is more focused and conceptually simpler. This is essentially the implementation of an idea that @markshannon pointed out to me. Note that this change would be much smaller if we didn't have to deal with repr compatibility for builtin types that explicitly inherit tp slots (see expect_manually_inherited()). The alternative is to stop *explicitly* inheriting tp slots in static PyTypeObject values, which is churn that we can do separately. (cherry picked from commit 716c6771fcfd3be90bba9f888a579b36c02cdb13, AKA gh-121932)
* [3.12] gh-121905: Consistently use "floating-point" instead of "floating ↵Serhiy Storchaka2024-07-194-10/+10
| | | | | point" (GH-121907) (GH-122013) (cherry picked from commit 1a0c7b9ba48a2dffb70bb0c7327abae1d3e87356)
* [3.12] gh-121153: Fix some errors with use of _PyLong_CompactValue() (GH-121154)Serhiy Storchaka2024-07-171-13/+55
| | | | | | | * The result has type Py_ssize_t, not intptr_t. * Type cast between unsigned and signed integer types should be explicit. * Downcasting should be explicit. * Fix integer overflow check in sum(). (cherry picked from commit 1801545)
* [3.12] gh-121660: Fix `ga_getitem` by explicitly checking for `NULL` result ↵Miss Islington (bot)2024-07-141-0/+4
| | | | | | | | (GH-121661) (#121762) gh-121660: Fix `ga_getitem` by explicitly checking for `NULL` result (GH-121661) (cherry picked from commit bb802db8cfa35a88582be32fae05fe1cf8f237b1) Co-authored-by: sobolevn <mail@sobolevn.me>
* [3.12] gh-117482: Fix Builtin Types Slot Wrappers (gh-121632)Eric Snow2024-07-111-9/+32
| | | | | | | When builtin static types are initialized for a subinterpreter, various "tp" slots have already been inherited (for the main interpreter). This was interfering with the logic in add_operators() (in Objects/typeobject.c), causing a wrapper to get created when it shouldn't. This change fixes that by preserving the original data from the static type struct and checking that. (cherry picked from commit 5250a031332eb9499d5fc190d7287642e5a144b9, AKA gh-121602) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
* [3.12] GH-121439: Allow PyTupleObjects with an ob_size of 20 in the ↵Miss Islington (bot)2024-07-101-1/+1
| | | | | | | | free_list to be reused (gh-121428) (#121566) GH-121439: Allow PyTupleObjects with an ob_size of 20 in the free_list to be reused (gh-121428) (cherry picked from commit 9585a1a2a251aaa15baf6579e13dd3be0cb05f1f) Co-authored-by: satori1995 <132636720+satori1995@users.noreply.github.com>
* [3.12] gh-120384: Fix array-out-of-bounds crash in `list_ass_subscript` ↵Miss Islington (bot)2024-06-211-12/+33
| | | | | | | | (GH-120442) (#120825) gh-120384: Fix array-out-of-bounds crash in `list_ass_subscript` (GH-120442) (cherry picked from commit 8334a1b55c93068f5d243852029baa83377ff6c9) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
* [3.12] gh-119897: Revert buggy optimization which was removed in 3.13 (#120467)Irit Katriel2024-06-181-4/+2
|
* gh-120198: Fix race condition when editing __class__ with an audit hook ↵Ken Jin2024-06-121-1/+2
| | | | | active (GH-120195) Co-authored-by: Nadeshiko Manju <me@manjusaka.me>
* [3.12] gh-120298: Fix use-after-free in `list_richcompare_impl` (GH-120303) ↵Miss Islington (bot)2024-06-111-1/+8
| | | | | | | | | (#120339) gh-120298: Fix use-after-free in `list_richcompare_impl` (GH-120303) (cherry picked from commit 141babad9b4eceb83371bf19ba3a36b50dd05250) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
* [3.12] bpo-24766: doc= argument to subclasses of property not handled ↵Serhiy Storchaka2024-06-101-15/+4
| | | | | | | correctly (GH-2487) (GH-120312) (cherry picked from commit 4829522b8d3e1a28930f1cccfcc9635e035a0eb4) Co-authored-by: E. M. Bray <erik.bray@lri.fr>
* [3.12] gh-120155: Fix copy/paste error in HAVE_SUBOFFSETS_IN_LAST_DIM() ↵Miss Islington (bot)2024-06-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | (GH-120228) (#120240) gh-120155: Fix copy/paste error in HAVE_SUBOFFSETS_IN_LAST_DIM() (GH-120228) Don't hardcode 'dest' in HAVE_SUBOFFSETS_IN_LAST_DIM() macro of memoryobject.c, but use its 'view' parameter instead. Fix the Coverity issue: Error: COPY_PASTE_ERROR (CWE-398): Python-3.12.2/Objects/memoryobject.c:273:14: original: ""dest->suboffsets + (dest->ndim - 1)"" looks like the original copy. Python-3.12.2/Objects/memoryobject.c:274:14: copy_paste_error: ""dest"" in ""src->suboffsets + (dest->ndim - 1)"" looks like a copy-paste error. Python-3.12.2/Objects/memoryobject.c:274:14: remediation: Should it say ""src"" instead? GH- 272| assert(dest->ndim > 0 && src->ndim > 0); GH- 273| return (!HAVE_SUBOFFSETS_IN_LAST_DIM(dest) && GH- 274|-> !HAVE_SUBOFFSETS_IN_LAST_DIM(src) && GH- 275| dest->strides[dest->ndim-1] == dest->itemsize && GH- 276| src->strides[src->ndim-1] == src->itemsize); (cherry picked from commit 90b75405260467814c93738a3325645918d4ea51) Co-authored-by: Victor Stinner <vstinner@python.org>
* [3.12] gh-109218: Improve documentation for the complex() constructor ↵Serhiy Storchaka2024-05-302-6/+12
| | | | | | | | | | | | | | | | (GH-119687) (ПР-119805) * Remove the equivalence with real+imag*1j which can be incorrect in corner cases (non-finite numbers, the sign of zeroes). * Separately document the three roles of the constructor: parsing a string, converting a number, and constructing a complex from components. * Document positional-only parameters of complex(), float(), int() and bool() as positional-only. * Add examples for complex() and int(). * Specify the grammar of the string for complex(). * Improve the grammar of the string for float(). * Describe more explicitly the behavior when real and/or imag arguments are complex numbers. (This will be deprecated in future.) (cherry picked from commit ec1ba264607b2b7b98d2602f5536a1d02981efc6)
* [3.12] gh-119011: `type.__type_params__` now return an empty tuple ↵Jelle Zijlstra2024-05-281-1/+4
| | | | | | | (GH-119296) (#119681) (cherry picked from commit 6b240c2308a044e38623900ccb8fa58c3549d4ae) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
* Fix some missing null checks. (GH-118721)Miss Islington (bot)2024-05-101-5/+8
| | | | | (cherry picked from commit 7e6fcab20003b07621dc02ea78d6ea2fda500371) Co-authored-by: Steve Dower <steve.dower@python.org>
* [3.12] gh-118272: Clear generator frame's locals when the generator is ↵Irit Katriel2024-05-021-0/+1
| | | | closed (#118451)
* [3.12] GH-117881: fix athrow().throw()/asend().throw() concurrent access ↵Thomas Grainger2024-05-021-0/+37
| | | | | | | (GH-117882) (#118458) GH-117881: fix athrow().throw()/asend().throw() concurrent access (GH-117882) (cherry picked from commit fc7e1aa3c001bbce25973261fba457035719a559)
* [3.12] GH-117894: prevent aclose()/athrow() being re-used after ↵Thomas Grainger2024-04-251-1/+8
| | | | | | StopIteration (GH-117851) (GH-118226) (cherry picked from commit 7d369d471cf2b067c4d795d70b75201c48b46f5b)
* [3.12] gh-113964: Don't prevent new threads until all non-daemon threads ↵Sam Gross2024-03-191-1/+1
| | | | | | | | | | | | | | exit (GH-116677) (#117029) Starting in Python 3.12, we prevented calling fork() and starting new threads during interpreter finalization (shutdown). This has led to a number of regressions and flaky tests. We should not prevent starting new threads (or `fork()`) until all non-daemon threads exit and finalization starts in earnest. This changes the checks to use `_PyInterpreterState_GetFinalizing(interp)`, which is set immediately before terminating non-daemon threads. (cherry picked from commit 60e105c1c11ecca1680d03c38aa06bcc77a28714)
* [3.12] gh-116714: Handle errors correctly in `PyFloat_GetInfo` (GH-116715) ↵Miss Islington (bot)2024-03-131-8/+13
| | | | | | | | | (#116722) gh-116714: Handle errors correctly in `PyFloat_GetInfo` (GH-116715) (cherry picked from commit fcd49b4f47f1edd9a2717f6619da7e7af8ea73cf) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
* [3.12] gh-110819: Fix ‘kind’ may be used uninitialized warning in ↵Miss Islington (bot)2024-03-121-28/+35
| | | | | | | | `longobject` (GH-116599) (#116648) gh-110819: Fix ‘kind’ may be used uninitialized warning in `longobject` (GH-116599) (cherry picked from commit eb947cdc1374842a32fa82249ba3c688abf252dc) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
* [3.12] gh-116296: Fix refleak in reduce_newobj() corner case (GH-116297) ↵Miss Islington (bot)2024-03-041-0/+1
| | | | | | | | (#116299) (cherry picked from commit 17c4849981905fb1c9bfbb2b963b6ee12e3efb2c) Co-authored-by: Erlend E. Aasland <erlend@python.org> Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
* [3.12] gh-100762: Fix optimization in gen_close (GH-111069) (#115818)Miss Islington (bot)2024-02-221-2/+3
| | | | | | gh-100762: Fix optimization in gen_close (GH-111069) (cherry picked from commit 0db2517687efcf5ec0174a32398ec1564b3204f1) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
* [3.12] gh-115618: Remove improper Py_XDECREFs in property methods ↵Serhiy Storchaka2024-02-171-3/+0
| | | | | (GH-115619) (GH-115620) (cherry picked from commit 090dd21ab9379d6a2a6923d6cbab697355fb7165)
* [3.12] gh-112087: Fix reduce logic for the empty reverse iterator for list ↵Donghee Na2024-02-141-7/+6
| | | | (gh-115471)
* [3.12] gh-113560: Improve docstrings for set.issubset() and set.issuperset() ↵Miss Islington (bot)2024-01-271-2/+10
| | | | | | | (GH-113562) (GH-114644) (cherry picked from commit 11c582235d86b6020710eff282eeb381a7bf7bb7) Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
* [3.12] gh-106293: Fix typos in Objects/object_layout.md (GH-106294) (#114158)Miss Islington (bot)2024-01-161-3/+3
| | | | | | (cherry picked from commit 60ca37fdee52cc4ff318b6e9ddbb260e8583b33b) Co-authored-by: Mano Sriram <mano.sriram0@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
* [3.12] Document the `co_lines` method on code objects (#113682) (#113686)Alex Waygood2024-01-031-1/+1
| | | | | (cherry-picked from commit f1f839243251fef7422c31d6a7c3c747e0b5e27c) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
* [3.12] gh-110383: Improve accuracy of str.split() and str.rsplit() ↵Hugo van Kemenade2023-12-222-5/+9
| | | | | | docstrings (GH-113355) (#113379) Co-authored-by: Erlend E. Aasland <erlend@python.org>
* [3.12] gh-112125: Fix None.__ne__(None) returning NotImplemented instead of ↵Victor Stinner2023-12-072-1/+7
| | | | | | | | | … (#112827) gh-112125: Fix None.__ne__(None) returning NotImplemented instead of False (#112504) (cherry picked from commit 9c3458e05865093dd55d7608810a9d0ef0765978) Co-authored-by: andrewluotechnologies <44252973+andrewluotechnologies@users.noreply.github.com>
* [3.12] gh-112625: Protect bytearray from being freed by misbehaving iterator ↵Miss Islington (bot)2023-12-041-1/+4
| | | | | | | inside bytearray.join (GH-112626) (GH-112693) (cherry picked from commit 0e732d0997cff08855d98c17af4dd5527f10e419) Co-authored-by: chilaxan <chilaxan@gmail.com>
* [3.12] gh-111058: Change coro.cr_frame/gen.gi_frame to be None for a closed ↵Miss Islington (bot)2023-12-011-1/+1
| | | | coroutine/generator. (GH-112428) (#112589)
* [3.12] gh-109894: Fix initialization of static `MemoryError` in ↵Miss Islington (bot)2023-11-281-4/+0
| | | | | | | | | | | | | | | subinterpreter (gh-110911) (gh-111238) Fixes GH-109894 * set `interp.static_objects.last_resort_memory_error.args` to empty tuple to avoid crash on `PyErr_Display()` call * allow `_PyExc_InitGlobalObjects()` to be called on subinterpreter init --------- (cherry picked from commit 47d3e2ed930a9f3d228aed4f62133737dae74cf7) Co-authored-by: Radislav Chugunov <52372310+chgnrdv@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
* [3.12] gh-106931: Intern Statically Allocated Strings Globally (gh-107272) ↵Eric Snow2023-11-271-3/+69
| | | | | | | | | (gh-110713) We tried this before with a dict and for all interned strings. That ran into problems due to interpreter isolation. However, exclusively using a per-interpreter cache caused some inconsistency that can eliminate the benefit of interning. Here we circle back to using a global cache, but only for statically allocated strings. We also use a more-basic _Py_hashtable_t for that global cache instead of a dict. Ideally we would only have the global cache, but the optional isolation of each interpreter's allocator means that a non-static string object must not outlive its interpreter. Thus we would have to store a copy of each such interned string in the global cache, tied to the main interpreter. (cherry-picked from commit b72947a8d26915156323ccfd04d273199ecb870c)
* [3.12] GH-109052: Use the base opcode when comparing code objects (GH-112329)Tian Gao2023-11-231-2/+2
|
* [3.12] gh-112266: Remove `(if defined)` part from `__dict__` and ↵Miss Islington (bot)2023-11-191-4/+4
| | | | | | | | `__weakref__` docstrings (GH-112268) (#112270) gh-112266: Remove `(if defined)` part from `__dict__` and `__weakref__` docstrings (GH-112268) (cherry picked from commit f8129146ef9e1b71609ef4becc5d508061970733) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
* [3.12] gh-110543: Fix CodeType.replace in presence of comprehensions ↵Miss Islington (bot)2023-11-081-0/+29
| | | | | | | | (GH-110586) (#111866) gh-110543: Fix CodeType.replace in presence of comprehensions (GH-110586) (cherry picked from commit 0b718e6407da65b838576a2459d630824ca62155) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
* [3.12] GH-94438: Restore ability to jump over None tests (GH-111243)Miss Islington (bot)2023-10-241-0/+2
| | | | (cherry picked from commit 6640f1d8d2462ca0877e1d2789e1721767e9caf2) Co-authored-by: Savannah Ostrowski <sostrowski@microsoft.com>
* [3.12] gh-110782: Fix crash when TypeVar is constructed with keyword args ↵Miss Islington (bot)2023-10-121-18/+20
| | | | | | | | (GH-110784) (#110787) gh-110782: Fix crash when TypeVar is constructed with keyword args (GH-110784) (cherry picked from commit d2a536b1706d4a79303b7ac53684bb82eac2de23) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
* [3.12] Fix typos in docs and comments (#109619) (#109621)Alex Waygood2023-10-021-1/+1
| | | | | | Fix typos in docs and comments (#109619) Co-authored-by: Heinz-Alexander Fuetterer <35225576+afuetterer@users.noreply.github.com>
generated by cgit v0.12 at 2026-01-03 14:24:14 (GMT)