summaryrefslogtreecommitdiffstats
path: root/Objects
Commit message (Collapse)AuthorAgeFilesLines
* [3.13] GH-127953: Make line number lookup O(1) regardless of the size of the ↵Mark Shannon2025-04-071-0/+3
| | | | | code object (#129127) GH-127953: Make line number lookup O(1) regardless of the size of the code object (GH-128350)
* [3.13] gh-131719: add NULL pointer check to `_PyMem_FreeDelayed` (gh-131720) ↵Miss Islington (bot)2025-03-251-1/+3
| | | | | | | (gh-131722) (cherry picked from commit 0a91456ad14bb598646f50bf8f034e8887c0c468) Co-authored-by: Tomasz Pytel <tompytel@gmail.com>
* [3.13] gh-131113: Fix data race in dict.popitem() (gh-131115) (#131119)Miss Islington (bot)2025-03-111-8/+8
| | | | | | | The clearing of the key, hash, and value need to use atomic operations to avoid a data race with concurrent read operations. (cherry picked from commit c00ac578241b3213ceb79c1f32bc83ea471f02da) Co-authored-by: Sam Gross <colesbury@gmail.com>
* [3.13] gh-130851: Only intern constants of types generated by the compiler ↵Sam Gross2025-03-081-2/+34
| | | | | | | | | | | | | | | (GH-130901) (#130953) The free-threading build interns and immortalizes most constants generated by the bytecode compiler. However, users can construct their own code objects with arbitrary constants. We should not intern or immortalize these objects if they are not of a type that we know how to handle. This change fixes a reference leak failure in the recently added `test_code.test_unusual_constants` test. It also addresses a potential crash that could occur when attempting to destroy an immortalized object during interpreter shutdown. (cherry picked from commit 12db45211d411583cbe272c7ba6811a811b721ca)
* [3.13] gh-130932: Fix incorrect exception handling in ↵Miss Islington (bot)2025-03-071-1/+3
| | | | | | | | | | | | | | | | | | | _PyModule_IsPossiblyShadowing (GH-130934) (#130939) gh-130932: Fix incorrect exception handling in _PyModule_IsPossiblyShadowing (GH-130934) I chose to not raise an exception here because I think it would be confusing for module attribute access to start raising something other than AttributeError if e.g. the cwd goes away Without the change in moduleobject.c ``` ./python.exe -m unittest test.test_import.ImportTests.test_script_shadowing_stdlib_cwd_failure ... Assertion failed: (PyErr_Occurred()), function _PyObject_SetAttributeErrorContext, file object.c, line 1253. ``` (cherry picked from commit 0a9ae5ed48e6ea078f67ba03635c1c26209b5def) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
* [3.13] gh-130851: Don't crash when deduping unusual code constants ↵Miss Islington (bot)2025-03-051-6/+12
| | | | | | | | | | | | | | | (GH-130853) (#130880) The bytecode compiler only generates a few different types of constants, like str, int, tuple, slices, etc. Users can construct code objects with various unusual constants, including ones that are not hashable or not even constant. The free threaded build previously crashed with a fatal error when confronted with these constants. Instead, treat distinct objects of otherwise unhandled types as not equal for the purposes of deduplication. (cherry picked from commit 2905690a91bf72cdf0fb919b5193849bb67732e2) Co-authored-by: Sam Gross <colesbury@gmail.com>
* [3.13] gh-130547: Fix race between dict_dealloc and split_keys_entry_added ↵Miss Islington (bot)2025-03-051-1/+1
| | | | | | | | (gh-130778) (gh-130833) gh-130547: Fix race between dict_dealloc and split_keys_entry_added (gh-130778) (cherry picked from commit 80e6d3ec4972220587c8b883161311a49ea8d0ff) Co-authored-by: Donghee Na <donghee.na@python.org>
* [3.13] gh-130794: Process interpreter QSBR queue in _PyMem_AbandonDelayed. ↵Sam Gross2025-03-041-8/+20
| | | | | | | (gh-130808) (#130857) This avoids a case where the interpreter's queue of memory to be freed could grow rapidly if there are many short lived threads. (cherry picked from commit 2f6e0e9f7001769be746ee96356656d3ebdc7f96)
* [3.13] Postpone <stdbool.h> inclusion after Python.h (#130641) (#130675)Victor Stinner2025-02-281-2/+2
| | | | | | | | | | | | | Postpone <stdbool.h> inclusion after Python.h (#130641) Remove inclusions prior to Python.h. <stdbool.h> will cause <features.h> to be included before Python.h can define some macros to enable some additional features, causing multiple types not to be defined down the line. (cherry picked from commit 830f04b5056db92ba96387db0a778dcd19a39522) Co-authored-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
* [3.13] gh-117657: Enable test_opcache under TSAN (GH-129831) (GH-130597)Sam Gross2025-02-262-3/+5
| | | | | | | | | | Fix a few thread-safety bugs to enable test_opcache when run with TSAN: * Use relaxed atomics when clearing `ht->_spec_cache.getitem` (gh-115999) * Add temporary suppression for type slot modifications (gh-127266) * Use atomic load when reading `*dictptr` (cherry picked from commit f151d271591ec525eaf01fa7b128e575374888b9)
* [3.13] gh-130163: Fix crashes related to PySys_GetObject() (GH-130503) ↵Serhiy Storchaka2025-02-251-1/+7
| | | | | | | | | | (GH-130556) The use of PySys_GetObject() and _PySys_GetAttr(), which return a borrowed reference, has been replaced by using one of the following functions, which return a strong reference and distinguish a missing attribute from an error: _PySys_GetOptionalAttr(), _PySys_GetOptionalAttrString(), _PySys_GetRequiredAttr(), and _PySys_GetRequiredAttrString(). (cherry picked from commit 0ef4ffeefd1737c18dc9326133c7894d58108c2e)
* [3.13] gh-128714: Fix function object races in `__annotate__`, ↵Xuanteng Huang2025-02-242-46/+203
| | | | | | | | | | | | `__annotations__` and `__type_params__` in free-threading build (GH-129016) (#129729) * gh-128714: Fix function object races in `__annotate__`, `__annotations__` and `__type_params__` in free-threading build (#129016) (cherry picked from commit 55f17b77c305be877ac856d6426b13591cbc7fc8) --------- Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
* [3.13] gh-128396: Fix a crash when inline comprehension has the same … ↵Tian Gao2025-02-191-2/+9
| | | | | | (#130311) [3.13] gh-128396: Fix a crash when inline comprehension has the same local variable as the outside scope (GH-130235) (cherry picked from commit ccf17323c218a2fdcf7f4845d3eaa74ebddefa44)
* [3.13] gh-130230: Fix crash in pow() with only Decimal third argument ↵Miss Islington (bot)2025-02-181-0/+20
| | | | | | | | (GH-130237) (GH-130246) (cherry picked from commit b93b7e566e5a4efe7f077af2083140e50bd2b08f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
* [3.13] gh-82045: Correct and deduplicate "isprintable" docs; add test. ↵Stan Ulbrych2025-02-173-20/+10
| | | | | | | | | | | | | | | | | | | | (GH-130127) We had the definition of what makes a character "printable" documented in three places, giving two different definitions. The definition in the comment on `_PyUnicode_IsPrintable` was inverted; correct that. With that correction, the two definitions turn out to be equivalent -- but to confirm that, you have to go look up, or happen to know, that those are the only five "Other" categories and only three "Separator" categories in the Unicode character database. That makes it hard for the reader to tell whether they really are the same, or if there's some subtle difference in the intended semantics. Fix that by cutting the C API docs' and the C comment's copies of the subtle details, in favor of referring to the Python-level docs. That ensures it's explicit that these are all meant to agree, and also lets us concentrate improvements to the wording in one place. Speaking of which, borrow some ideas from the C comment, along with other tweaks, to hopefully add a bit more clarity to that one newly-centralized copy in the docs. Also add a thorough test that the implementation agrees with this definition. Author: Greg Price <gnprice@gmail.com> Co-authored-by: Greg Price <gnprice@gmail.com> (cherry picked from commit 3402e133ef26736296c07992266a82b181a5d532)
* [3.13] gh-128759: Fix accesses to `tp_version_tag`. (GH-129750) (GH-130042)Sam Gross2025-02-121-8/+3
| | | | | | | | | | We should use a relaxed atomic load in the free threading build in `PyType_Modified()` because that's called without the type lock held. It's not necessary to use atomics in `type_modified_unlocked()`. We should also use `FT_ATOMIC_STORE_UINT_RELAXED()` instead of the `UINT32` variant because `tp_version_tag` is declared as `unsigned int`. (cherry picked from commit 57f45ee2d8ee23c2a1d1daba4095a5a044169419)
* [3.13] gh-128133: use relaxed atomics for hash of bytes (GH-128412) (#130022)Sam Gross2025-02-121-31/+39
| | | | | (cherry picked from commit 0706bab1c0985761cdbc07ab448f98c717276b36) Co-authored-by: Abhijeet <abhijeetsharma2002@gmail.com>
* [3.13] gh-129967: Fix race condition in `repr(set)` (gh-129978) (gh-130020)Sam Gross2025-02-111-2/+11
| | | | | | | | | The call to `PySequence_List()` could temporarily unlock and relock the set, allowing the items to be cleared and return the incorrect notation `{}` for a empty set (it should be `set()`). (cherry picked from commit a7427f2db937adb4c787754deb4c337f1894fe86) Co-authored-by: T. Wouters <thomas@python.org>
* [3.13] gh-128100: Use atomic dictionary load in ↵Miss Islington (bot)2025-02-101-0/+4
| | | | | | | `_PyObject_GenericGetAttrWithDict` (GH-128297) (GH-129979) (cherry picked from commit 47d2cb8eb7595df5940225867dbb66b6dd59413a) Co-authored-by: Bogdan Romanyuk <65823030+wrongnull@users.noreply.github.com>
* [3.13] gh-117657: Fix data race in `dict_dict_merge` (gh-129755) (gh-129808)Miss Islington (bot)2025-02-071-1/+1
| | | | | | Found while running `test_load_attr_module` from `test_opcache` under TSan. (cherry picked from commit 34379d0a593e5a76e2f754cdd7fccb79f25a4613) Co-authored-by: Sam Gross <colesbury@gmail.com>
* [3.13] gh-129668: Fix thread-safety of MemoryError freelist in free threaded ↵Sam Gross2025-02-061-26/+36
| | | | | | | | | build (gh-129704) (gh-129742) The MemoryError freelist was not thread-safe in the free threaded build. Use a mutex to protect accesses to the freelist. Unlike other freelists, the MemoryError freelist is not performance sensitive. (cherry picked from commit 51b4edb1a4092f60d84f7d14eb41c12085e39c31)
* [3.13] gh-129643: Fix `PyList_Insert` in free-threading builds (GH-129680) ↵sobolevn2025-02-061-2/+2
| | | | | (#129725) (cherry picked from commit 63f0406d5ad25a55e49c3903b29407c50a17cfd5)
* [3.13] gh-129643: fix thread safety of `PyList_SetItem` (#129644) (#129677)Kumar Aditya2025-02-051-3/+3
| | | gh-129643: fix thread safety of `PyList_SetItem` (#129644)
* [3.13] gh-128078: Use `PyErr_SetRaisedException` in ↵Miss Islington (bot)2025-02-031-22/+10
| | | | | | | | | `_PyGen_SetStopIterationValue` (GH-128287) (#128789) gh-128078: Use `PyErr_SetRaisedException` in `_PyGen_SetStopIterationValue` (GH-128287) (cherry picked from commit 402b91da87052878b4e7e8946ba91bdf4ee4bebe) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
* [3.13] gh-128078: Clear exception in `anext` before calling ↵Miss Islington (bot)2025-01-132-0/+3
| | | | | | | | | `_PyGen_SetStopIterationValue` (GH-128780) (#128785) gh-128078: Clear exception in `anext` before calling `_PyGen_SetStopIterationValue` (GH-128780) (cherry picked from commit 76ffaef729c91bb79da6df2ade48f3ec51118300) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
* [3.13] gh-128759: fix data race in `type_modified_unlocked` (GH-128764) ↵Miss Islington (bot)2025-01-131-0/+6
| | | | | | | | (#128769) * gh-128759: fix data race in `type_modified_unlocked` (GH-128764) (cherry picked from commit 6e1e78054060ad326f26dd8dbf12adfedbb52883) Co-authored-by: sobolevn <mail@sobolevn.me>
* [3.13] gh-126862: Use `Py_ssize_t` instead of `int` when processing the ↵Miss Islington (bot)2025-01-101-4/+4
| | | | | | | | number of super-classes (GH-127523) (#128699) gh-126862: Use `Py_ssize_t` instead of `int` when processing the number of super-classes (GH-127523) (cherry picked from commit 2fcdc8488c32d18f4567f797094068a994777f16) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
* [3.13] gh-127903: Fix a crash on debug builds when calling ↵Miss Islington (bot)2025-01-031-3/+6
| | | | | | | | `Objects/unicodeobject::_copy_characters` (GH-127876) (#128458) gh-127903: Fix a crash on debug builds when calling `Objects/unicodeobject::_copy_characters`` (GH-127876) (cherry picked from commit 46cb6340d7bad955edfc0a20f6a52dabc03b0932) Co-authored-by: Alexander Shadchin <shadchin@yandex-team.com>
* [3.13] gh-128013: fix data race in PyUnicode_AsUTF8AndSize on free-threading ↵Kumar Aditya2025-01-021-59/+107
| | | | (#128021) (#128417)
* [3.13] Clean up redundant ifdef in list getitem (GH-128257) (#128276)Miss Islington (bot)2024-12-261-4/+0
| | | | | | | | Clean up redundant ifdef in list getitem (GH-128257) It's already inside a `Py_GIL_DISABLED` block so the `#else` clause is always unused. (cherry picked from commit 42f7a00ae8b6b3fa09115e24b9512216c6c8978e) Co-authored-by: da-woods <dw-git@d-woods.co.uk>
* [3.13] gh-128198: Add missing error checks for usages of PyIter_Next() ↵Serhiy Storchaka2024-12-262-0/+8
| | | | | | | (GH-128199) (GH-128272) (cherry picked from commit 5c814c83cdd3dc42bd9682106ffb7ade7ce6b5b3) Co-authored-by: Yan Yanchii <yyanchiy@gmail.com>
* [3.13] gh-126076: Account for relocated objects in tracemalloc (GH-126077) ↵Pablo Galindo Salgado2024-12-114-15/+5
| | | | | (#127823) (cherry picked from commit 30aeb00d367d0cc9e5a7603371636cddea09f1c0)
* [3.13] gh-127563: use `dk_log2_index_bytes=3` in empty dicts (GH-127568) ↵Miss Islington (bot)2024-12-111-1/+4
| | | | | | | | (GH-127798) This fixes a UBSan failure (unaligned zero-size memcpy) in `dictobject.c`. (cherry picked from commit 9af96f440618304e7cc609c246e1f8c8b2d7a119) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
* [3.13] gh-127582: Make object resurrection thread-safe for free threading. ↵Sam Gross2024-12-054-20/+41
| | | | | | | | | | | | | | | (GH-127612) (GH-127659) Objects may be temporarily "resurrected" in destructors when calling finalizers or watcher callbacks. We previously undid the resurrection by decrementing the reference count using `Py_SET_REFCNT`. This was not thread-safe because other threads might be accessing the object (modifying its reference count) if it was exposed by the finalizer, watcher callback, or temporarily accessed by a racy dictionary or list access. This adds internal-only thread-safe functions for temporary object resurrection during destructors. (cherry picked from commit f4f530804b9d8f089eba0f157ec2144c03b13651)
* [3.13] gh-127536: Add missing locks in listobject.c (GH-127580) (GH-127613)Sam Gross2024-12-041-10/+40
| | | | | We were missing locks around some list operations in the free threading build. (cherry picked from commit e51da64ac3bc6cd45339864db32d05115af39ead)
* [3.13] gh-127521: Mark list as "shared" before resizing if necessary ↵Miss Islington (bot)2024-12-031-0/+20
| | | | | | | | | | | | | | (GH-127524) (GH-127533) In the free threading build, if a non-owning thread resizes a list, it must use QSBR to free the old list array because there may be a concurrent access (without a lock) from the owning thread. To match the pattern in dictobject.c, we just mark the list as "shared" before resizing if it's from a non-owning thread and not already marked as shared. (cherry picked from commit c7dec02de2ed4baf3cd22ad094350265b52c18af) Co-authored-by: Sam Gross <colesbury@gmail.com>
* [3.13] gh-113841: fix possible undefined division by 0 in _Py_c_pow() ↵Miss Islington (bot)2024-12-021-1/+1
| | | | | | | | | | | (GH-127211) (#127216) Note, that transformed expression is not an equivalent for original one (1/exp(-x) != exp(x) in general for floating-point numbers). Though, the difference seems to be ~1ULP for good libm implementations. It's more interesting why division was used from beginning. Closest algorithm I've found (no error checks, of course;)) - it's Algorithm 190 from ACM: https://dl.acm.org/doi/10.1145/366663.366679. It uses subtraction in the exponent. (cherry picked from commit f7bb658124aba74be4c13f498bf46cfded710ef9) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
* [3.13] Fix Unicode encode_wstr_utf8() (#127420) (#127505)Bénédikt Tran2024-12-021-1/+1
| | | | | | | Fix Unicode encode_wstr_utf8() (#127420) Raise RuntimeError instead of RuntimeWarning. Co-authored-by: Victor Stinner <vstinner@python.org>
* [3.13] gh-127316: fix incorrect assertion in setting `__class__` in ↵Miss Islington (bot)2024-11-291-1/+1
| | | | | | | | free-threading (GH-127399) (#127422) gh-127316: fix incorrect assertion in setting `__class__` in free-threading (GH-127399) (cherry picked from commit 45c5cba318a19dda3ee6f9fc84781cc7a2fbde80) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
* [3.13] gh-127020: Make `PyCode_GetCode` thread-safe for free threading ↵Miss Islington (bot)2024-11-211-27/+51
| | | | | | | | | (GH-127043) (GH-127107) Some fields in PyCodeObject are lazily initialized. Use atomics and critical sections to make their initializations and accesses thread-safe. (cherry picked from commit 3926842117feffe5d2c9727e1899bea5ae2adb28) Co-authored-by: Sam Gross <colesbury@gmail.com>
* [3.13] gh-126980: Fix `bytearray.__buffer__` crash on `PyBUF_{READ,WRITE}` ↵sobolevn2024-11-191-4/+4
| | | | | | | (GH-126981) (#127023) (cherry picked from commit 3932e1db5353bbcf3e3c1133cc9d2cde654cb645) Co-authored-by: Victor Stinner <vstinner@python.org>
* [3.13] gh-126594: Fix typeobject.c wrap_buffer() cast (GH-126754) (#127004)Miss Islington (bot)2024-11-191-3/+3
| | | | | | | | | | gh-126594: Fix typeobject.c wrap_buffer() cast (GH-126754) Reject flags smaller than INT_MIN. (cherry picked from commit 84f07c3a4cbcfe488ccfb4030571be0bc4de7e45) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
* [3.13] gh-126341: add release check to `__iter__` method of `memoryview` ↵Miss Islington (bot)2024-11-131-0/+1
| | | | | | | | | | | | (GH-126759) (#126778) gh-126341: add release check to `__iter__` method of `memoryview` (GH-126759) (cherry picked from commit a12690ef49e8fc8a3af4c5f1757eb3caffb35e03) Co-authored-by: Ritvik Pasham <ritvikpasham@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: sobolevn <mail@sobolevn.me>
* [3.13] gh-116510: Fix a Crash Due to Shared Immortal Interned Strings ↵Miss Islington (bot)2024-11-122-18/+86
| | | | | | | | | | | | | | | | | | | | | | | | | (gh-124865) (gh-125709) (GH-125204) * gh-116510: Fix a Crash Due to Shared Immortal Interned Strings (gh-124865) Fix a crash caused by immortal interned strings being shared between sub-interpreters that use basic single-phase init. In that case, the string can be used by an interpreter that outlives the interpreter that created and interned it. For interpreters that share obmalloc state, also share the interned dict with the main interpreter. This is an un-revert of gh-124646 that then addresses the Py_TRACE_REFS failures identified by gh-124785. (cherry picked from commit f2cb39947093feda3ff85b8dc820922cc5e5f954) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com> * [3.13] gh-125286: Share the Main Refchain With Legacy Interpreters (gh-125709) They used to be shared, before 3.12. Returning to sharing them resolves a failure on Py_TRACE_REFS builds. --------- Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
* [3.13] gh-126303: Fix pickling and copying of os.sched_param objects ↵Miss Islington (bot)2024-11-051-0/+6
| | | | | | | (GH-126336) (GH-126423) (cherry picked from commit d3840503b0f590ee574fbdf3c96626ff8b3c45f6) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
* [3.13] gh-116938: Fix `dict.update` docstring and remove erraneous full stop ↵Miss Islington (bot)2024-10-291-2/+2
| | | | | | | | | from `dict` documentation (GH-125421) (#126150) gh-116938: Fix `dict.update` docstring and remove erraneous full stop from `dict` documentation (GH-125421) (cherry picked from commit 5527c4051c0b58218ce69044f92b45f1d66ed43f) Co-authored-by: Prometheus3375 <35541026+Prometheus3375@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
* [3.13] gh-125608: Trigger dictionary watchers when inline values change ↵Miss Islington (bot)2024-10-251-6/+15
| | | | | | | | | | (GH-125611) (GH-125982) Dictionary watchers on an object's attributes dictionary (`object.__dict__`) were not triggered when the managed dictionary used the object's inline values. (cherry picked from commit 5989eb74463c26780632f17f221d6bf4c9372a01) Co-authored-by: Sam Gross <colesbury@gmail.com>
* [3.13] gh-123930: Better error for "from imports" when script shadows module ↵Shantanu2024-10-241-12/+16
| | | | | | | (GH-123929) (#125937) gh-123930: Better error for "from imports" when script shadows module (#123929) (cherry picked from commit 500f5338a8fe13719478589333fcd296e8e8eb02)
* [3.13] gh-125590: Allow FrameLocalsProxy to delete and pop keys from extra ↵Miss Islington (bot)2024-10-211-6/+70
| | | | | | | | locals (GH-125616) (#125797) gh-125590: Allow FrameLocalsProxy to delete and pop keys from extra locals (GH-125616) (cherry picked from commit 5b7a872b26a9ba6c93d7c2109559a82d1c1612de) Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
* [3.13] gh-125221: Fix free-threading data race in `object.__reduce_ex__` ↵Miss Islington (bot)2024-10-112-15/+13
| | | | | | | | (GH-125267) (#125305) gh-125221: Fix free-threading data race in `object.__reduce_ex__` (GH-125267) (cherry picked from commit b12e99261e656585ffbaa395af7c5dbaee5ad1ad) Co-authored-by: Sam Gross <colesbury@gmail.com>
generated by cgit v0.12 at 2026-01-04 10:31:56 (GMT)