From c932f5c1e531f5a3cbf0ce664e4bcd22aa04994d Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Sat, 13 Jun 2020 09:18:52 -0700 Subject: bpo-40957: Fix refleak in _Py_fopen_obj() (GH-20827) Signed-off-by: Christian Heimes (cherry picked from commit 9672912e8f90374fd31b37ca0fb7cefbc6f4c555) Co-authored-by: Christian Heimes --- .../next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst | 1 + Python/fileutils.c | 1 + 2 files changed, 2 insertions(+) create mode 100644 Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst b/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst new file mode 100644 index 0000000..f99c374 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2020-06-12-12-21-54.bpo-40957.Z8n6I6.rst @@ -0,0 +1 @@ +Fix refleak in _Py_fopen_obj() when PySys_Audit() fails diff --git a/Python/fileutils.c b/Python/fileutils.c index 439bc35..22e72bd 100644 --- a/Python/fileutils.c +++ b/Python/fileutils.c @@ -1461,6 +1461,7 @@ _Py_fopen_obj(PyObject *path, const char *mode) path_bytes = PyBytes_AS_STRING(bytes); if (PySys_Audit("open", "Osi", path, mode, 0) < 0) { + Py_DECREF(bytes); return NULL; } -- cgit v0.12