From 05da1ef40a4285ee859836d67bced63504dd89b2 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Tue, 29 Apr 2014 01:58:06 +0200 Subject: Issue #18727: improve test coverage of the csv module by testing for DictWriter.writerows. Patch by Muhammad Jehanzeb. --- Lib/test/test_csv.py | 10 ++++++++++ Misc/ACKS | 1 + 2 files changed, 11 insertions(+) diff --git a/Lib/test/test_csv.py b/Lib/test/test_csv.py index 7e2485f..7c31ac7 100644 --- a/Lib/test/test_csv.py +++ b/Lib/test/test_csv.py @@ -575,6 +575,16 @@ class TestDictFields(unittest.TestCase): fileobj.readline() # header self.assertEqual(fileobj.read(), "10,,abc\r\n") + def test_write_multiple_dict_rows(self): + fileobj = StringIO() + writer = csv.DictWriter(fileobj, fieldnames=["f1", "f2", "f3"]) + writer.writeheader() + self.assertEqual(fileobj.getvalue(), "f1,f2,f3\r\n") + writer.writerows([{"f1": 1, "f2": "abc", "f3": "f"}, + {"f1": 2, "f2": 5, "f3": "xyz"}]) + self.assertEqual(fileobj.getvalue(), + "f1,f2,f3\r\n1,abc,f\r\n2,5,xyz\r\n") + def test_write_no_fields(self): fileobj = StringIO() self.assertRaises(TypeError, csv.DictWriter, fileobj) diff --git a/Misc/ACKS b/Misc/ACKS index 6e27c36..2aa087e 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -613,6 +613,7 @@ Juhana Jauhiainen Rajagopalasarma Jayakrishnan Zbigniew Jędrzejewski-Szmek Julien Jehannet +Muhammad Jehanzeb Drew Jenkins Flemming Kjær Jensen Philip H. Jensen -- cgit v0.12