From 19a02ba69dd908bcc5fe45263fb9c956ed9f7ffc Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Tue, 15 Apr 2003 22:09:45 +0000 Subject: Fix three (!) object leaks in the code for assignment to __bases__. --- Objects/typeobject.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Objects/typeobject.c b/Objects/typeobject.c index 6ef5f75..8f9deae 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -164,10 +164,12 @@ mro_subclasses(PyTypeObject *type, PyObject* temp) else { PyObject* tuple; tuple = Py_BuildValue("OO", subclass, old_mro); + Py_DECREF(old_mro); if (!tuple) return -1; if (PyList_Append(temp, tuple) < 0) return -1; + Py_DECREF(tuple); } if (mro_subclasses(subclass, temp) < 0) return -1; @@ -256,7 +258,7 @@ type_set_bases(PyTypeObject *type, PyObject *value, void *context) for (i = 0; i < PyList_Size(temp); i++) { PyTypeObject* cls; PyObject* mro; - PyArg_ParseTuple(PyList_GetItem(temp, i), + PyArg_ParseTuple(PyList_GET_ITEM(temp, i), "OO", &cls, &mro); Py_DECREF(cls->tp_mro); cls->tp_mro = mro; -- cgit v0.12