From 289898cdbb1d4526ce45e600ed2843a14d1feb0d Mon Sep 17 00:00:00 2001 From: Fred Drake Date: Sat, 4 Aug 2001 03:11:25 +0000 Subject: Plug a memory leak in Py_InitModule4(): when PyDict_SetItemString() failed, the object being inserted was not being DECREFed. This closes SF bug #444486. --- Python/modsupport.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Python/modsupport.c b/Python/modsupport.c index eb0818c..8fad54a 100644 --- a/Python/modsupport.c +++ b/Python/modsupport.c @@ -60,14 +60,18 @@ Py_InitModule4(char *name, PyMethodDef *methods, char *doc, v = PyCFunction_New(ml, passthrough); if (v == NULL) return NULL; - if (PyDict_SetItemString(d, ml->ml_name, v) != 0) + if (PyDict_SetItemString(d, ml->ml_name, v) != 0) { + Py_DECREF(v); return NULL; + } Py_DECREF(v); } if (doc != NULL) { v = PyString_FromString(doc); - if (v == NULL || PyDict_SetItemString(d, "__doc__", v) != 0) + if (v == NULL || PyDict_SetItemString(d, "__doc__", v) != 0) { + Py_DECREF(v); return NULL; + } Py_DECREF(v); } return m; -- cgit v0.12