From 76ec53c64df498eebc08d5cf7e53d2fc01064384 Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Mon, 15 Jun 1998 18:01:34 +0000 Subject: Subject: Bug in PC/import_nt.c From: Dan Pierson To: "Mark Hammond (E-mail)" , "Guido van Rossum (E-mail)" Date: Mon, 8 Jun 1998 17:25:07 -0400 RegistryQueryValue requires that its fourth argument be initialized to the length of the buffer being passed in, this wasn't being done. I also split the call and status test into two lines with a local variable so that I could look at the status in the debugger. --- PC/import_nt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PC/import_nt.c b/PC/import_nt.c index 1769697..b506694 100644 --- a/PC/import_nt.c +++ b/PC/import_nt.c @@ -45,6 +45,7 @@ FILE *PyWin_FindRegisteredModule( const char *moduleName, struct filedescr **ppF FILE *fp; HKEY keyBase = PyWin_IsWin32s() ? HKEY_CLASSES_ROOT : HKEY_LOCAL_MACHINE; int modNameSize; + long regStat; // Calculate the size for the sprintf buffer. // Get the size of the chars only, plus 1 NULL. @@ -53,7 +54,9 @@ FILE *PyWin_FindRegisteredModule( const char *moduleName, struct filedescr **ppF moduleKey = alloca(bufSize); sprintf(moduleKey, "Software\\Python\\PythonCore\\%s\\Modules\\%s%s", PyWin_DLLVersionString, moduleName, debugString); - if (RegQueryValue(keyBase, moduleKey, pathBuf, &modNameSize)!=ERROR_SUCCESS) + modNameSize = bufSize; + regStat = RegQueryValue(keyBase, moduleKey, pathBuf, &modNameSize); + if (regStat!=ERROR_SUCCESS) return NULL; // use the file extension to locate the type entry. for (fdp = _PyImport_Filetab; fdp->suffix != NULL; fdp++) { -- cgit v0.12