From 8ae9e6a627ed6630b577a540d611c226959280ce Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 6 Dec 2016 11:02:12 +0100 Subject: warnings: Fix the issue number The fix for catch_warnings() is the issue #28835 (not the issue #28089). --- Lib/test/test_warnings/__init__.py | 4 ++-- Misc/NEWS | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Lib/test/test_warnings/__init__.py b/Lib/test/test_warnings/__init__.py index 60fa780..0cddf4a 100644 --- a/Lib/test/test_warnings/__init__.py +++ b/Lib/test/test_warnings/__init__.py @@ -945,7 +945,7 @@ class CatchWarningTests(BaseTest): self.assertTrue(wmod.filters is orig_filters) def test_record_override_showwarning_before(self): - # Issue #28089: If warnings.showwarning() was overriden, make sure + # Issue #28835: If warnings.showwarning() was overriden, make sure # that catch_warnings(record=True) overrides it again. text = "This is a warning" wmod = self.module @@ -970,7 +970,7 @@ class CatchWarningTests(BaseTest): self.assertEqual(my_log, []) def test_record_override_showwarning_inside(self): - # Issue #28089: It is possible to override warnings.showwarning() + # Issue #28835: It is possible to override warnings.showwarning() # in the catch_warnings(record=True) context manager. text = "This is a warning" wmod = self.module diff --git a/Misc/NEWS b/Misc/NEWS index bfe3cc9..fed13a3 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -26,7 +26,7 @@ Core and Builtins Library ------- -- Issue #28089: Fix a regression introduced in warnings.catch_warnings(): +- Issue #28835: Fix a regression introduced in warnings.catch_warnings(): call warnings.showwarning() if it was overriden inside the context manager. - Issue #27172: To assist with upgrades from 2.7, the previously documented -- cgit v0.12