From 19276f184f00829ce55ce0e98f8db06d93b7d665 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 23 Mar 2015 21:20:27 +0100 Subject: Issue #23654: Fix faulthandler._stack_overflow() for the Intel C Compiler (ICC) Issue #23654: Turn off ICC's tail call optimization for the stack_overflow generator. ICC turns the recursive tail call into a loop. Patch written by Matt Frank. --- Misc/ACKS | 1 + Modules/faulthandler.c | 9 ++++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Misc/ACKS b/Misc/ACKS index cdee1bb..d0d5e25 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -436,6 +436,7 @@ Doug Fort Chris Foster John Fouhy Andrew Francis +Matt Frank Stefan Franke Martin Franklin Kent Frazier diff --git a/Modules/faulthandler.c b/Modules/faulthandler.c index 01e7beb..c729414 100644 --- a/Modules/faulthandler.c +++ b/Modules/faulthandler.c @@ -911,7 +911,14 @@ faulthandler_fatal_error_py(PyObject *self, PyObject *args) } #if defined(HAVE_SIGALTSTACK) && defined(HAVE_SIGACTION) -static Py_uintptr_t +#ifdef __INTEL_COMPILER + /* Issue #23654: Turn off ICC's tail call optimization for the + * stack_overflow generator. ICC turns the recursive tail call into + * a loop. */ +# pragma intel optimization_level 0 +#endif +static +Py_uintptr_t stack_overflow(Py_uintptr_t min_sp, Py_uintptr_t max_sp, size_t *depth) { /* allocate 4096 bytes on the stack at each call */ -- cgit v0.12