From adc8211e0084126c1d3190022929c3bffef12ce6 Mon Sep 17 00:00:00 2001 From: Jesus Cea Date: Fri, 5 Oct 2012 04:58:38 +0200 Subject: #16112: platform.architecture does not correctly escape argument to /usr/bin/file. Use 'communicate()' and decode the bytes --- Lib/platform.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Lib/platform.py b/Lib/platform.py index 6776a25..f2dd520 100755 --- a/Lib/platform.py +++ b/Lib/platform.py @@ -997,12 +997,11 @@ def _syscmd_file(target,default=''): return default target = _follow_symlinks(target) try: - with open(DEV_NULL) as dev_null: - proc = subprocess.Popen(['file', '-b', '--', target], - stdout=subprocess.PIPE, stderr=dev_null) + proc = subprocess.Popen(['file', '-b', '--', target], + stdout=subprocess.PIPE, stderr=dev_null) except (AttributeError,os.error): return default - output = proc.stdout.read() + output = proc.communicate()[0].decode("latin-1") rc = proc.wait() if not output or rc: return default -- cgit v0.12 From 685fffa8f427b3a768b232170752565d58c32112 Mon Sep 17 00:00:00 2001 From: Jesus Cea Date: Fri, 5 Oct 2012 05:21:42 +0200 Subject: #16112: platform.architecture does not correctly escape argument to /usr/bin/file. Fix original patch --- Lib/platform.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/platform.py b/Lib/platform.py index f2dd520..eedc11c 100755 --- a/Lib/platform.py +++ b/Lib/platform.py @@ -997,8 +997,8 @@ def _syscmd_file(target,default=''): return default target = _follow_symlinks(target) try: - proc = subprocess.Popen(['file', '-b', '--', target], - stdout=subprocess.PIPE, stderr=dev_null) + proc = subprocess.Popen(['file', target], + stdout=subprocess.PIPE, stderr=subprocess.STDOUT) except (AttributeError,os.error): return default output = proc.communicate()[0].decode("latin-1") -- cgit v0.12