From 0b624f69b59597a4d88de46f1f5cc0751bf22887 Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Sat, 20 Jul 2002 00:38:01 +0000 Subject: unpack_string(): avoid a compiler warning (about a real bug!) by copying the result of fgetc() into an int variable before testing it for EOF. --- Modules/_hotshot.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Modules/_hotshot.c b/Modules/_hotshot.c index 7bd99c8..625d1ba 100644 --- a/Modules/_hotshot.c +++ b/Modules/_hotshot.c @@ -305,6 +305,7 @@ unpack_string(LogReaderObject *self, PyObject **pvalue) int i; int len; int err; + int ch; char *buf; if ((err = unpack_packed_int(self, &len, 0))) @@ -312,7 +313,9 @@ unpack_string(LogReaderObject *self, PyObject **pvalue) buf = malloc(len); for (i=0; i < len; i++) { - if ((buf[i] = fgetc(self->logfp)) == EOF) { + ch = fgetc(self->logfp); + buf[i] = ch; + if (ch == EOF) { free(buf); return ERR_EOF; } -- cgit v0.12