From 4f2dab5c337f202b8fe3058108efc40cb1a0a724 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Fri, 27 May 2011 16:46:51 +0200 Subject: Revert my commit 7ba176c2f558: "Avoid useless "++" at the end of functions Warnings found by the Clang Static Analyzer." Most people prefer ++ at the end of functions. --- Objects/setobject.c | 2 +- Objects/unicodeobject.c | 2 +- Python/compile.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Objects/setobject.c b/Objects/setobject.c index ebfddb3..2e62518 100644 --- a/Objects/setobject.c +++ b/Objects/setobject.c @@ -616,7 +616,7 @@ set_repr(PySetObject *so) Py_UNICODE_COPY(u, PyUnicode_AS_UNICODE(listrepr)+1, newsize-2); u += newsize-2; - *u = '}'; + *u++ = '}'; Py_DECREF(listrepr); if (Py_TYPE(so) != &PySet_Type) { diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 309159c..4361908 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -6474,7 +6474,7 @@ PyUnicode_EncodeDecimal(Py_UNICODE *s, } } /* 0-terminate the output string */ - *output = '\0'; + *output++ = '\0'; Py_XDECREF(exc); Py_XDECREF(errorHandler); return 0; diff --git a/Python/compile.c b/Python/compile.c index 96d01cd..34e7603 100644 --- a/Python/compile.c +++ b/Python/compile.c @@ -3744,11 +3744,11 @@ assemble_lnotab(struct assembler *a, struct instr *i) a->a_lnotab_off += 2; if (d_bytecode) { *lnotab++ = d_bytecode; - *lnotab = d_lineno; + *lnotab++ = d_lineno; } else { /* First line of a block; def stmt, etc. */ *lnotab++ = 0; - *lnotab = d_lineno; + *lnotab++ = d_lineno; } a->a_lineno = i->i_lineno; a->a_lineno_off = a->a_offset; @@ -3793,7 +3793,7 @@ assemble_emit(struct assembler *a, struct instr *i) if (i->i_hasarg) { assert(size == 3 || size == 6); *code++ = arg & 0xff; - *code = arg >> 8; + *code++ = arg >> 8; } return 1; } -- cgit v0.12