From 0f9eec19ee1652a61d4b2e860e599c617d88b707 Mon Sep 17 00:00:00 2001 From: Ross Lagerwall Date: Sat, 7 Apr 2012 07:09:57 +0200 Subject: Don't Py_DECREF NULL variable in io.IncrementalNewlineDecoder. Found with Clang's Static Analyzer. --- Misc/NEWS | 2 ++ Modules/_io/textio.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Misc/NEWS b/Misc/NEWS index b4a0091..29bf33a 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -19,6 +19,8 @@ Core and Builtins Library ------- +- Don't Py_DECREF NULL variable in io.IncrementalNewlineDecoder. + - Issue #8515: Set __file__ when run file in IDLE. Initial patch by Bruce Frederiksen. diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c index 833a527..ae105e5 100644 --- a/Modules/_io/textio.c +++ b/Modules/_io/textio.c @@ -460,7 +460,7 @@ _PyIncrementalNewlineDecoder_decode(PyObject *_self, output = PyUnicode_FromKindAndData(kind, translated, out); PyMem_Free(translated); if (!output) - goto error; + return NULL; } self->seennl |= seennl; } -- cgit v0.12