From 53aa1d7c5756eda92bd3276dd38dfa1f0c4bcee2 Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Tue, 20 Dec 2011 13:29:45 -0600 Subject: fix possible if unlikely leak --- Objects/unicodeobject.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index d13c547..c4cfe1b 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -8888,9 +8888,13 @@ unicode_maketrans(PyUnicodeObject *null, PyObject *args) /* create entries for translating chars in x to those in y */ for (i = 0; i < PyUnicode_GET_SIZE(x); i++) { key = PyLong_FromLong(PyUnicode_AS_UNICODE(x)[i]); + if (!key) + goto err; value = PyLong_FromLong(PyUnicode_AS_UNICODE(y)[i]); - if (!key || !value) + if (!value) { + Py_DECREF(key); goto err; + } res = PyDict_SetItem(new, key, value); Py_DECREF(key); Py_DECREF(value); -- cgit v0.12