From 6ad22c41c2f1adb39d023d8dcc779d96d73695f6 Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Wed, 2 May 2001 07:12:39 +0000 Subject: Plug a memory leak in list(), when appending to the result list. --- Objects/abstract.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/Objects/abstract.c b/Objects/abstract.c index a5f97a1..8ee1e5a 100644 --- a/Objects/abstract.c +++ b/Objects/abstract.c @@ -1291,11 +1291,15 @@ PySequence_List(PyObject *v) break; } if (i < n) - PyList_SET_ITEM(result, i, item); - else if (PyList_Append(result, item) < 0) { - Py_DECREF(result); - result = NULL; - break; + PyList_SET_ITEM(result, i, item); /* steals ref */ + else { + int status = PyList_Append(result, item); + Py_DECREF(item); /* append creates a new ref */ + if (status < 0) { + Py_DECREF(result); + result = NULL; + break; + } } } -- cgit v0.12