From 0f6b47a338fdc0063c651657fcbb6908da27f0b9 Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Sun, 30 Jan 2011 12:19:35 +0000 Subject: #10680: fix mutually exclusive arguments in argument groups. --- Lib/argparse.py | 1 + Lib/test/test_argparse.py | 40 ++++++++++++++++++++++++++++++++++++++++ Misc/NEWS | 3 +++ 3 files changed, 44 insertions(+) diff --git a/Lib/argparse.py b/Lib/argparse.py index 5fd82da..de3cd11 100644 --- a/Lib/argparse.py +++ b/Lib/argparse.py @@ -1495,6 +1495,7 @@ class _ArgumentGroup(_ActionsContainer): self._defaults = container._defaults self._has_negative_number_optionals = \ container._has_negative_number_optionals + self._mutually_exclusive_groups = container._mutually_exclusive_groups def _add_action(self, action): action = super(_ArgumentGroup, self)._add_action(action) diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py index 36415f4..03c95fa 100644 --- a/Lib/test/test_argparse.py +++ b/Lib/test/test_argparse.py @@ -2540,6 +2540,46 @@ class TestMutuallyExclusiveOptionalsMixed(MEMixin, TestCase): ''' +class TestMutuallyExclusiveInGroup(MEMixin, TestCase): + + def get_parser(self, required=None): + parser = ErrorRaisingArgumentParser(prog='PROG') + titled_group = parser.add_argument_group( + title='Titled group', description='Group description') + mutex_group = \ + titled_group.add_mutually_exclusive_group(required=required) + mutex_group.add_argument('--bar', help='bar help') + mutex_group.add_argument('--baz', help='baz help') + return parser + + failures = ['--bar X --baz Y', '--baz X --bar Y'] + successes = [ + ('--bar X', NS(bar='X', baz=None)), + ('--baz Y', NS(bar=None, baz='Y')), + ] + successes_when_not_required = [ + ('', NS(bar=None, baz=None)), + ] + + usage_when_not_required = '''\ + usage: PROG [-h] [--bar BAR | --baz BAZ] + ''' + usage_when_required = '''\ + usage: PROG [-h] (--bar BAR | --baz BAZ) + ''' + help = '''\ + + optional arguments: + -h, --help show this help message and exit + + Titled group: + Group description + + --bar BAR bar help + --baz BAZ baz help + ''' + + class TestMutuallyExclusiveOptionalsAndPositionalsMixed(MEMixin, TestCase): def get_parser(self, required): diff --git a/Misc/NEWS b/Misc/NEWS index 80c4639..c58114a 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -91,6 +91,9 @@ Library - Issue #10961: The new pydoc server now better handles exceptions raised during request handling. +- Issue #10680: Fix mutually exclusive arguments for argument groups in + argparse. + Build ----- -- cgit v0.12