From 5bba60290b4ac8c95ac46cfdaba5deee37be1fab Mon Sep 17 00:00:00 2001 From: Senthil Kumaran Date: Fri, 3 Jan 2020 18:14:18 -0800 Subject: bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile for the (#17774) desired behavior under windows platform. Suggestion by David Bolen --- Lib/test/test_urllibnet.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py index df118dc..ef33e3a 100644 --- a/Lib/test/test_urllibnet.py +++ b/Lib/test/test_urllibnet.py @@ -1,4 +1,3 @@ -import tempfile import unittest from test import test_support from test.test_urllib2net import skip_ftp_test_on_travis @@ -224,9 +223,10 @@ class urlopen_FTPTest(unittest.TestCase): with test_support.transient_internet(self.FTP_TEST_FILE): try: - for _ in range(self.NUM_FTP_RETRIEVES): - with tempfile.NamedTemporaryFile() as fp: - urllib.FancyURLopener().retrieve(self.FTP_TEST_FILE, fp.name) + for file_num in range(self.NUM_FTP_RETRIEVES): + with test_support.temp_dir() as td: + urllib.FancyURLopener().retrieve(self.FTP_TEST_FILE, + os.path.join(td, str(file_num))) except IOError as e: self.fail("Failed FTP retrieve while accessing ftp url " "multiple times.\n Error message was : %s" % e) -- cgit v0.12