From fea7fc1ab5b1b6803401940250ce347a6aef6080 Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Tue, 22 Sep 2015 22:59:35 -0400 Subject: Issue #16893: Move idlelib.EditorWindow.HelpDialog deprecation warning so it is not triggered on import. The problem is creation of a now-unused instance "helpDialog = HelpDialog()", left for back compatibility. So instead trigger the warning when that instance or another is used. --- Lib/idlelib/EditorWindow.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Lib/idlelib/EditorWindow.py b/Lib/idlelib/EditorWindow.py index f9f5337..f78fe53 100644 --- a/Lib/idlelib/EditorWindow.py +++ b/Lib/idlelib/EditorWindow.py @@ -72,11 +72,6 @@ def _find_module(fullname, path=None): class HelpDialog(object): def __init__(self): - import warnings as w - w.warn("EditorWindow.HelpDialog is no longer used by Idle.\n" - "It will be removed in 3.6 or later.\n" - "It has been replaced by private help.HelpWindow\n", - DeprecationWarning, stacklevel=2) self.parent = None # parent of help window self.dlg = None # the help window iteself @@ -88,6 +83,11 @@ class HelpDialog(object): near - a Toplevel widget (e.g. EditorWindow or PyShell) to use as a reference for placing the help window """ + import warnings as w + w.warn("EditorWindow.HelpDialog is no longer used by Idle.\n" + "It will be removed in 3.6 or later.\n" + "It has been replaced by private help.HelpWindow\n", + DeprecationWarning, stacklevel=2) if self.dlg is None: self.show_dialog(parent) if near: -- cgit v0.12