From 37cfb0a920bd01ee81ce7bebebfe510d01d751d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Charles-Fran=C3=A7ois=20Natali?= Date: Fri, 28 Jun 2013 19:25:45 +0200 Subject: Issue #17914: Use os.cpu_count() instead of multiprocessing.cpu_count() where applicable. --- Doc/library/multiprocessing.rst | 2 +- Lib/concurrent/futures/process.py | 2 +- Lib/multiprocessing/pool.py | 8 +++----- Lib/test/regrtest.py | 8 ++------ 4 files changed, 7 insertions(+), 13 deletions(-) diff --git a/Doc/library/multiprocessing.rst b/Doc/library/multiprocessing.rst index 2c1ec9b..95d1b1f 100644 --- a/Doc/library/multiprocessing.rst +++ b/Doc/library/multiprocessing.rst @@ -1664,7 +1664,7 @@ with the :class:`Pool` class. callbacks and has a parallel map implementation. *processes* is the number of worker processes to use. If *processes* is - ``None`` then the number returned by :func:`cpu_count` is used. If + ``None`` then the number returned by :func:`os.cpu_count` is used. If *initializer* is not ``None`` then each worker process will call ``initializer(*initargs)`` when it starts. diff --git a/Lib/concurrent/futures/process.py b/Lib/concurrent/futures/process.py index 3c20b93..abb99d6 100644 --- a/Lib/concurrent/futures/process.py +++ b/Lib/concurrent/futures/process.py @@ -331,7 +331,7 @@ class ProcessPoolExecutor(_base.Executor): _check_system_limits() if max_workers is None: - self._max_workers = multiprocessing.cpu_count() + self._max_workers = os.cpu_count() or 1 else: self._max_workers = max_workers diff --git a/Lib/multiprocessing/pool.py b/Lib/multiprocessing/pool.py index bcf8a37..8082ad6 100644 --- a/Lib/multiprocessing/pool.py +++ b/Lib/multiprocessing/pool.py @@ -17,10 +17,11 @@ import threading import queue import itertools import collections +import os import time import traceback -from multiprocessing import Process, cpu_count, TimeoutError +from multiprocessing import Process, TimeoutError from multiprocessing.util import Finalize, debug # @@ -147,10 +148,7 @@ class Pool(object): self._initargs = initargs if processes is None: - try: - processes = cpu_count() - except NotImplementedError: - processes = 1 + processes = os.cpu_count() or 1 if processes < 1: raise ValueError("Number of processes must be at least 1") diff --git a/Lib/test/regrtest.py b/Lib/test/regrtest.py index e6eef16..bd816dd 100755 --- a/Lib/test/regrtest.py +++ b/Lib/test/regrtest.py @@ -508,12 +508,8 @@ def main(tests=None, testdir=None, verbose=0, quiet=False, elif o in ('-j', '--multiprocess'): use_mp = int(a) if use_mp <= 0: - try: - import multiprocessing - # Use all cores + extras for tests that like to sleep - use_mp = 2 + multiprocessing.cpu_count() - except (ImportError, NotImplementedError): - use_mp = 3 + # Use all cores + extras for tests that like to sleep + use_mp = 2 + (os.cpu_count() or 1) if use_mp == 1: use_mp = None elif o == '--header': -- cgit v0.12