From 9c6e6a0c7fbc2a15bbd3092e8a75bec80da58b3d Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Wed, 28 Sep 2011 08:09:05 -0400 Subject: don't check that the first character is XID_Continue Current, XID_Continue is a superset of XID_Start, but that may sometime change. --- Lib/test/test_pep3131.py | 5 +---- Objects/unicodeobject.c | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Lib/test/test_pep3131.py b/Lib/test/test_pep3131.py index df0f64d..9a3c7ee 100644 --- a/Lib/test/test_pep3131.py +++ b/Lib/test/test_pep3131.py @@ -19,10 +19,7 @@ class PEP3131Test(unittest.TestCase): 𝔘𝔫𝔦𝔠𝔬𝔡𝔢 = 1 # On wide builds, this is normalized, but on narrow ones it is not. See # #12746. - try: - self.assertIn("𝔘𝔫𝔦𝔠𝔬𝔡𝔢", dir()) - except AssertionError: - raise unittest.case._ExpectedFailure(sys.exc_info()) + self.assertIn("Unicode", dir()) def test_invalid(self): try: diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 2ae1947..aff205d 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -10196,7 +10196,7 @@ PyUnicode_IsIdentifier(PyObject *self) if (!_PyUnicode_IsXidStart(first) && first != 0x5F /* LOW LINE */) return 0; - for (i = 0; i < PyUnicode_GET_LENGTH(self); i++) + for (i = 1; i < PyUnicode_GET_LENGTH(self); i++) if (!_PyUnicode_IsXidContinue(PyUnicode_READ(kind, data, i))) return 0; return 1; -- cgit v0.12