From c55485bc6d4a22026e12ccc6b772984059468a86 Mon Sep 17 00:00:00 2001 From: "Gregory P. Smith" Date: Mon, 17 Mar 2008 20:16:47 +0000 Subject: use PyBUF_LOCK instead of PyBUF_SIMPLE for bsddb data access as it'll often be using the data buffer provided without the GIL held. --- Modules/_bsddb.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Modules/_bsddb.c b/Modules/_bsddb.c index 52d83ec..02973aa 100644 --- a/Modules/_bsddb.c +++ b/Modules/_bsddb.c @@ -312,10 +312,9 @@ static Py_buffer * _malloc_view(PyObject *obj) "Py_buffer malloc failed"); return NULL; } - /* XXX(gps): PyBUF_LOCKDATA is desired to prevent other theads from - trashing the data buffer while we release the GIL during the db - operation. see http://bugs.python.org/issue1035 */ - if (PyObject_GetBuffer(obj, view, PyBUF_SIMPLE) == -1) { + /* We use PyBUF_LOCK to prevent other threads from trashing the data + buffer while we release the GIL. http://bugs.python.org/issue1035 */ + if (PyObject_GetBuffer(obj, view, PyBUF_LOCK) == -1) { PyMem_Free(view); return NULL; } -- cgit v0.12