From bf644c5571a8e2acb380c7a1288af217f0be7cd6 Mon Sep 17 00:00:00 2001 From: Senthil Kumaran Date: Tue, 23 Oct 2012 11:07:02 -0700 Subject: Fix the windows buildbot permission error - close the fd of tempfile beffore unlinking --- Lib/test/test_urllib.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py index 2eac4e3..d8c3512 100644 --- a/Lib/test/test_urllib.py +++ b/Lib/test/test_urllib.py @@ -278,12 +278,13 @@ Content-Type: text/html; charset=iso-8859-1 def test_file_notexists(self): fd, tmp_file = tempfile.mkstemp() tmp_fileurl = 'file://localhost/' + tmp_file.replace(os.path.sep, '/') - - self.assertTrue(os.path.exists(tmp_file)) - with urlopen(tmp_fileurl) as fobj: - self.assertTrue(fobj) - - os.unlink(tmp_file) + try: + self.assertTrue(os.path.exists(tmp_file)) + with urlopen(tmp_fileurl) as fobj: + self.assertTrue(fobj) + finally: + os.close(fd) + os.unlink(tmp_file) self.assertFalse(os.path.exists(tmp_file)) with self.assertRaises(urllib.error.URLError): urlopen(tmp_fileurl) -- cgit v0.12