From 90180c1c3f260ee3085eb3a41aca478b41ac90a8 Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Tue, 16 Jul 2013 01:59:30 -0700 Subject: Move the leftlink to the end of the block structure. The current pattern of memory access will update both the leftlink and rightlink at the same time, so they should be positioned side-by-side for better cache locality. Keeping the leftlink at the front of the structure would make sense only if the paired updates were eliminated by backporting changesets 49a9c734304d, 3555cc0ca35b, ae9ee46bd471, and 744dd749e25b. However, that isn't likely to happen, so we're better off with the leftlink at the end of the structure. --- Modules/_collectionsmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c index f175fca..b0fa23d 100644 --- a/Modules/_collectionsmodule.c +++ b/Modules/_collectionsmodule.c @@ -47,9 +47,9 @@ */ typedef struct BLOCK { - struct BLOCK *leftlink; PyObject *data[BLOCKLEN]; struct BLOCK *rightlink; + struct BLOCK *leftlink; } block; #define MAXFREEBLOCKS 10 -- cgit v0.12