From 5fac8af22ce0fc18c19d02e4f08eaba144b77d07 Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Mon, 6 Jun 2011 20:22:56 -0700 Subject: Checking if an unsigned long is < 0 is pointless. Found by LLVM/clang 2.9. --- Modules/mmapmodule.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c index 36ca67d..38f6157 100644 --- a/Modules/mmapmodule.c +++ b/Modules/mmapmodule.c @@ -645,9 +645,9 @@ mmap_move_method(mmap_object *self, PyObject *args) return NULL; } else { /* bounds check the values */ - if (cnt < 0 || (cnt + dest) < cnt || (cnt + src) < cnt || - src < 0 || src > self->size || (src + cnt) > self->size || - dest < 0 || dest > self->size || (dest + cnt) > self->size) { + if ((cnt + dest) < cnt || (cnt + src) < cnt || + src > self->size || (src + cnt) > self->size || + dest > self->size || (dest + cnt) > self->size) { PyErr_SetString(PyExc_ValueError, "source, destination, or count out of range"); return NULL; -- cgit v0.12