From ffeee3518a9ccb0d6375bf06abe2cf8a6bc9e5b8 Mon Sep 17 00:00:00 2001 From: Meador Inge Date: Mon, 13 Feb 2012 22:08:39 -0600 Subject: Issue #13979: Fix ctypes.util.find_library ldconfig regex --- Lib/ctypes/util.py | 19 +------------------ Misc/NEWS | 3 +++ 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/Lib/ctypes/util.py b/Lib/ctypes/util.py index 1881e89..1bb7d1d 100644 --- a/Lib/ctypes/util.py +++ b/Lib/ctypes/util.py @@ -171,22 +171,6 @@ elif os.name == "posix": else: - def _findLib_ldconfig(name): - # XXX assuming GLIBC's ldconfig (with option -p) - expr = r'/[^\(\)\s]*lib%s\.[^\(\)\s]*' % re.escape(name) - with contextlib.closing(os.popen('/sbin/ldconfig -p 2>/dev/null')) as f: - data = f.read() - res = re.search(expr, data) - if not res: - # Hm, this works only for libs needed by the python executable. - cmd = 'ldd %s 2>/dev/null' % sys.executable - with contextlib.closing(os.popen(cmd)) as f: - data = f.read() - res = re.search(expr, data) - if not res: - return None - return res.group(0) - def _findSoname_ldconfig(name): import struct if struct.calcsize('l') == 4: @@ -203,8 +187,7 @@ elif os.name == "posix": abi_type = mach_map.get(machine, 'libc6') # XXX assuming GLIBC's ldconfig (with option -p) - expr = r'(\S+)\s+\((%s(?:, OS ABI:[^\)]*)?)\)[^/]*(/[^\(\)\s]*lib%s\.[^\(\)\s]*)' \ - % (abi_type, re.escape(name)) + expr = r'\s+(lib%s\.[^\s]+)\s+\(%s' % (re.escape(name), abi_type) with contextlib.closing(os.popen('LC_ALL=C LANG=C /sbin/ldconfig -p 2>/dev/null')) as f: data = f.read() res = re.search(expr, data) diff --git a/Misc/NEWS b/Misc/NEWS index 9294e70..6180361a 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -113,6 +113,9 @@ Core and Builtins Library ------- +- Issue #13979: A bug in ctypes.util.find_library that caused + the wrong library name to be returned has been fixed. + - Issue #13993: HTMLParser is now able to handle broken end tags when strict=False. -- cgit v0.12