From 2a36b09ce7cd67503893412b53295717d66fee19 Mon Sep 17 00:00:00 2001 From: Raymond Hettinger Date: Mon, 19 Apr 2021 20:29:48 -0700 Subject: Improve the error message for choices(population, 10) (GH-25267) --- Lib/random.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Lib/random.py b/Lib/random.py index 0df2664..3a835ae 100644 --- a/Lib/random.py +++ b/Lib/random.py @@ -518,7 +518,15 @@ class Random(_random.Random): floor = _floor n += 0.0 # convert to float for a small speed improvement return [population[floor(random() * n)] for i in _repeat(None, k)] - cum_weights = list(_accumulate(weights)) + try: + cum_weights = list(_accumulate(weights)) + except TypeError: + if not isinstance(weights, int): + raise + k = weights + raise TypeError( + f'The number of choices must be a keyword argument: {k=}' + ) from None elif weights is not None: raise TypeError('Cannot specify both weights and cumulative weights') if len(cum_weights) != n: -- cgit v0.12