From 7be74cffbe96e9649a331260ba0fbf2c2b4a1de0 Mon Sep 17 00:00:00 2001 From: "Gregory P. Smith" Date: Sun, 1 Jun 2014 00:33:35 -0700 Subject: Remove the obsolete MAXFD constant and Popen._close_fds() method. They should have been removed years ago when removing the old pure Python implementation from the file. --- Lib/subprocess.py | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/Lib/subprocess.py b/Lib/subprocess.py index daa3e25..49aa6ab 100644 --- a/Lib/subprocess.py +++ b/Lib/subprocess.py @@ -469,10 +469,6 @@ if mswindows: __del__ = Close __str__ = __repr__ -try: - MAXFD = os.sysconf("SC_OPEN_MAX") -except: - MAXFD = 256 # This lists holds Popen instances for which the underlying process had not # exited at the time its __del__ method got called: those processes are wait()ed @@ -1335,16 +1331,6 @@ class Popen(object): errread, errwrite) - def _close_fds(self, fds_to_keep): - start_fd = 3 - for fd in sorted(fds_to_keep): - if fd >= start_fd: - os.closerange(start_fd, fd) - start_fd = fd + 1 - if start_fd <= MAXFD: - os.closerange(start_fd, MAXFD) - - def _execute_child(self, args, executable, preexec_fn, close_fds, pass_fds, cwd, env, startupinfo, creationflags, shell, -- cgit v0.12