From f8e74b12b00401b9cd6322fc339a1b9111e944df Mon Sep 17 00:00:00 2001 From: Peter Astrand Date: Sun, 7 Nov 2004 14:15:28 +0000 Subject: If close() fails in file_dealloc, then print an error message to stderr. close() can fail if the user is out-of-quota, for example. Fixes #959379. --- Objects/fileobject.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Objects/fileobject.c b/Objects/fileobject.c index 34f28e3..c08345c 100644 --- a/Objects/fileobject.c +++ b/Objects/fileobject.c @@ -300,12 +300,19 @@ static void drop_readahead(PyFileObject *); static void file_dealloc(PyFileObject *f) { + int sts = 0; if (f->weakreflist != NULL) PyObject_ClearWeakRefs((PyObject *) f); if (f->f_fp != NULL && f->f_close != NULL) { Py_BEGIN_ALLOW_THREADS - (*f->f_close)(f->f_fp); + sts = (*f->f_close)(f->f_fp); Py_END_ALLOW_THREADS + if (sts == EOF) +#ifdef HAVE_STRERROR + PySys_WriteStderr("close failed: [Errno %d] %s\n", errno, strerror(errno)); +#else + PySys_WriteStderr("close failed: [Errno %d]\n", errno); +#endif } PyMem_Free(f->f_setbuf); Py_XDECREF(f->f_name); -- cgit v0.12