From a78b627e2b8ee464ecba3788725872d63f8a6b34 Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Fri, 9 Sep 2016 00:25:03 +0200 Subject: Fix potential NULL pointer dereference in _imp_create_builtin PyModule_GetDef() can return NULL. Let's check the return value properly like in the other five cases. CID 1299590 --- Python/import.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Python/import.c b/Python/import.c index 17188c2..dfdd940 100644 --- a/Python/import.c +++ b/Python/import.c @@ -1077,6 +1077,10 @@ _imp_create_builtin(PyObject *module, PyObject *spec) } else { /* Remember pointer to module init function. */ def = PyModule_GetDef(mod); + if (def == NULL) { + Py_DECREF(name); + return NULL; + } def->m_base.m_init = p->initfunc; if (_PyImport_FixupExtensionObject(mod, name, name) < 0) { Py_DECREF(name); -- cgit v0.12