From a846f5ace80977f922e8295441afc668910fc894 Mon Sep 17 00:00:00 2001 From: R David Murray Date: Mon, 18 Mar 2013 00:18:12 -0400 Subject: #17448: Make test_sax skip if there are no xml parsers. Patch by Rafael Santos. --- Lib/test/test_sax.py | 4 ++-- Misc/ACKS | 1 + Misc/NEWS | 3 +++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_sax.py b/Lib/test/test_sax.py index bfa7d72..3efd972 100644 --- a/Lib/test/test_sax.py +++ b/Lib/test/test_sax.py @@ -3,11 +3,12 @@ from xml.sax import make_parser, ContentHandler, \ SAXException, SAXReaderNotAvailable, SAXParseException +import unittest try: make_parser() except SAXReaderNotAvailable: # don't try to test this module if we cannot create a parser - raise ImportError("no XML parsers available") + raise unittest.SkipTest("no XML parsers available") from xml.sax.saxutils import XMLGenerator, escape, unescape, quoteattr, \ XMLFilterBase from xml.sax.expatreader import create_parser @@ -18,7 +19,6 @@ import os.path import shutil from test import support from test.support import findfile, run_unittest -import unittest TEST_XMLFILE = findfile("test.xml", subdir="xmltestdata") TEST_XMLFILE_OUT = findfile("test.xml.out", subdir="xmltestdata") diff --git a/Misc/ACKS b/Misc/ACKS index d8533c4..b5c8059 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -947,6 +947,7 @@ Rich Salz Kevin Samborn Adrian Sampson Ilya Sandler +Rafael Santos Mark Sapiro Ty Sarna Hugh Sasse diff --git a/Misc/NEWS b/Misc/NEWS index c9c854d..af22318 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -967,6 +967,9 @@ Extension Modules Tests ----- +- Issue #17448: test_sax now skips if there are no xml parsers available + instead of raising an ImportError. + - Issue #11420: make test suite pass with -B/DONTWRITEBYTECODE set. Initial patch by Thomas Wouters. -- cgit v0.12