From d55162517da38138fed130607b311ed4cc62ec77 Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Sun, 6 Mar 2016 14:00:45 +0200 Subject: Issue #25718: Fixed pickling and copying the accumulate() iterator with total is None. --- Lib/test/test_itertools.py | 10 ++++++++++ Misc/NEWS | 3 +++ Modules/itertoolsmodule.c | 17 +++++++++++++++++ 3 files changed, 30 insertions(+) diff --git a/Lib/test/test_itertools.py b/Lib/test/test_itertools.py index 5b3ba7e..08c9f39 100644 --- a/Lib/test/test_itertools.py +++ b/Lib/test/test_itertools.py @@ -1398,6 +1398,16 @@ class TestExamples(unittest.TestCase): self.assertEqual(list(copy.deepcopy(it)), accumulated[1:]) self.assertEqual(list(copy.copy(it)), accumulated[1:]) + def test_accumulate_reducible_none(self): + # Issue #25718: total is None + it = accumulate([None, None, None], operator.is_) + self.assertEqual(next(it), None) + for proto in range(pickle.HIGHEST_PROTOCOL + 1): + it_copy = pickle.loads(pickle.dumps(it, proto)) + self.assertEqual(list(it_copy), [True, False]) + self.assertEqual(list(copy.deepcopy(it)), [True, False]) + self.assertEqual(list(copy.copy(it)), [True, False]) + def test_chain(self): self.assertEqual(''.join(chain('ABC', 'DEF')), 'ABCDEF') diff --git a/Misc/NEWS b/Misc/NEWS index fd9a4d6..70e7760 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -91,6 +91,9 @@ Core and Builtins Library ------- +- Issue #25718: Fixed pickling and copying the accumulate() iterator with + total is None. + - Issue #26475: Fixed debugging output for regular expressions with the (?x) flag. diff --git a/Modules/itertoolsmodule.c b/Modules/itertoolsmodule.c index cac02ad..11ce5ea 100644 --- a/Modules/itertoolsmodule.c +++ b/Modules/itertoolsmodule.c @@ -3460,6 +3460,23 @@ accumulate_next(accumulateobject *lz) static PyObject * accumulate_reduce(accumulateobject *lz) { + if (lz->total == Py_None) { + PyObject *it; + + if (PyType_Ready(&chain_type) < 0) + return NULL; + if (PyType_Ready(&islice_type) < 0) + return NULL; + it = PyObject_CallFunction((PyObject *)&chain_type, "(O)O", + lz->total, lz->it); + if (it == NULL) + return NULL; + it = PyObject_CallFunction((PyObject *)Py_TYPE(lz), "NO", + it, lz->binop ? lz->binop : Py_None); + if (it == NULL) + return NULL; + return Py_BuildValue("O(NiO)", &islice_type, it, 1, Py_None); + } return Py_BuildValue("O(OO)O", Py_TYPE(lz), lz->it, lz->binop?lz->binop:Py_None, lz->total?lz->total:Py_None); -- cgit v0.12