From 908d55dd7e395779ed1eb5c96664aca6297fedaa Mon Sep 17 00:00:00 2001 From: Yury Selivanov Date: Sun, 9 Oct 2016 12:15:08 -0400 Subject: Issue #28399: Remove UNIX socket from FS before binding. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Patch by Коренберг Марк. --- Lib/asyncio/unix_events.py | 11 +++++++++++ Lib/test/test_asyncio/test_unix_events.py | 12 +++++++----- Misc/NEWS | 3 +++ 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py index 42a8b85..65b61db 100644 --- a/Lib/asyncio/unix_events.py +++ b/Lib/asyncio/unix_events.py @@ -258,6 +258,17 @@ class _UnixSelectorEventLoop(selector_events.BaseSelectorEventLoop): sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) + # Check for abstract socket. `str` and `bytes` paths are supported. + if path[0] not in (0, '\x00'): + try: + if stat.S_ISSOCK(os.stat(path).st_mode): + os.remove(path) + except FileNotFoundError: + pass + except OSError as err: + # Directory may have permissions only to create socket. + logger.error('Unable to check or remove stale UNIX socket %r: %r', path, err) + try: sock.bind(path) except OSError as exc: diff --git a/Lib/test/test_asyncio/test_unix_events.py b/Lib/test/test_asyncio/test_unix_events.py index 0d54e3a..ce897ed 100644 --- a/Lib/test/test_asyncio/test_unix_events.py +++ b/Lib/test/test_asyncio/test_unix_events.py @@ -241,11 +241,13 @@ class SelectorEventLoopUnixSocketTests(test_utils.TestCase): with test_utils.unix_socket_path() as path: sock = socket.socket(socket.AF_UNIX) sock.bind(path) - with sock: - coro = self.loop.create_unix_server(lambda: None, path) - with self.assertRaisesRegex(OSError, - 'Address.*is already in use'): - self.loop.run_until_complete(coro) + sock.listen(1) + sock.close() + + coro = self.loop.create_unix_server(lambda: None, path) + srv = self.loop.run_until_complete(coro) + srv.close() + self.loop.run_until_complete(srv.wait_closed()) def test_create_unix_server_existing_path_nonsock(self): with tempfile.NamedTemporaryFile() as file: diff --git a/Misc/NEWS b/Misc/NEWS index db74991..90eed7d 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -385,6 +385,9 @@ Library - Issue #28372: Fix asyncio to support formatting of non-python coroutines. +- Issue #28399: Remove UNIX socket from FS before binding. + Patch by Коренберг Марк. + IDLE ---- -- cgit v0.12