From 90b20675bd042a3262642232f9d3e133e56a130c Mon Sep 17 00:00:00 2001 From: Georg Brandl Date: Tue, 28 Dec 2010 10:38:33 +0000 Subject: #10777: fix iteration over dict keys while mutating the dict. --- Lib/test/test_xml_etree.py | 9 +++++++++ Lib/xml/etree/ElementTree.py | 2 +- Misc/NEWS | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/Lib/test/test_xml_etree.py b/Lib/test/test_xml_etree.py index 08f7988..22fafa9 100644 --- a/Lib/test/test_xml_etree.py +++ b/Lib/test/test_xml_etree.py @@ -1841,6 +1841,15 @@ def check_issue6565(): """ +def check_issue10777(): + """ + Registering a namespace twice caused a "dictionary changed size during + iteration" bug. + + >>> ET.register_namespace('test10777', 'http://myuri/') + >>> ET.register_namespace('test10777', 'http://myuri/') + """ + # -------------------------------------------------------------------- diff --git a/Lib/xml/etree/ElementTree.py b/Lib/xml/etree/ElementTree.py index 53aa9e7..ba33879 100644 --- a/Lib/xml/etree/ElementTree.py +++ b/Lib/xml/etree/ElementTree.py @@ -1068,7 +1068,7 @@ _serialize = { def register_namespace(prefix, uri): if re.match("ns\d+$", prefix): raise ValueError("Prefix format reserved for internal use") - for k, v in _namespace_map.items(): + for k, v in list(_namespace_map.items()): if k == uri or v == prefix: del _namespace_map[k] _namespace_map[uri] = prefix diff --git a/Misc/NEWS b/Misc/NEWS index 8acc9e3..46b6233 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -18,6 +18,9 @@ Core and Builtins Library ------- +- Issue #10777: Fix "dictionary changed size during iteration" bug in + ElementTree register_namespace(). + - Issue #10626: test_logging now preserves logger disabled states. - Issue #10774: test_logging now removes temp files created during tests. -- cgit v0.12