From 660c8fc997f34b7474c23a993105a37b7277554f Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Thu, 30 Jun 2016 11:41:55 -0700 Subject: Issue #26665: Remove mis-use of ``$`` in activate.fish. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a revertion of cfc66e37eb8e. Thanks to 鄭景文 for the bug report. Thanks to Tin Tvrtković, Xiang Zhang, and Dan McCombs for diagnosing the issue. --- Lib/venv/scripts/posix/activate.fish | 4 ++-- Misc/NEWS | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Lib/venv/scripts/posix/activate.fish b/Lib/venv/scripts/posix/activate.fish index fb7f5c0..45391aa 100644 --- a/Lib/venv/scripts/posix/activate.fish +++ b/Lib/venv/scripts/posix/activate.fish @@ -55,8 +55,8 @@ if test -z "$VIRTUAL_ENV_DISABLE_PROMPT" # with the original prompt function renamed, we can override with our own. function fish_prompt # Prompt override? - if test -n "$__VENV_PROMPT__" - printf "%s%s%s" "$__VENV_PROMPT__" (set_color normal) (_old_fish_prompt) + if test -n "__VENV_PROMPT__" + printf "%s%s%s" "__VENV_PROMPT__" (set_color normal) (_old_fish_prompt) return end # ...Otherwise, prepend env diff --git a/Misc/NEWS b/Misc/NEWS index 330d170..f8ed7ac 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -13,6 +13,8 @@ Core and Builtins Library ------- +- Issue #26664: Fix activate.fish by removing mis-use of ``$``. + - Issue #22115: Fixed tracing Tkinter variables: trace_vdelete() with wrong mode no longer break tracing, trace_vinfo() now always returns a list of pairs of strings, tracing in the "u" mode now works. -- cgit v0.12